[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 4/9] x86/vmx: remove unused included headers from vmx.h
- To: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 23 Feb 2023 11:29:14 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PnkhHgXhbIc5suDHCbJSLzc4ACbBckevjobrv0aNAP0=; b=hBmZ6VkARxhoFe5DT8qU9dnSzhx6qfxLZzh40IKzQByYEfpOg62px0bjpDNbbweenOYRVewnEmihTjVYGarMqIS1n0sPI6fMB9TuS5TsBCnmIXM/oE6L8Q+JrHSTjWbwnGMKZxDErvpvnSL/8bBbz7WTgEOPEonXuaXhqg+jRPVKx5XRj4w3rDj578gp6TtIVztvbMdP+dwBA2hlgGz0yST2LBdUhJaQ8fBpa0OpmQNmsdCKZEm8Yck55noFe8qb3LHvXR26+XBDvLhSTKjbyl3yONQ0bz3thb0agghJBdJgA3U+dDNTa+YHUO/7NZQnvbE037zHGD6Gvz1Cm6clhA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EduRHxigKfJ3930eicl1jwzlATjZ95muFM7ORMpADa7wu9nxZSyYdtP5oMY5cjpqeTsQYwP+3nnPYbhrBU4FHYVGW1eZhhWUSbh29uz90DNL0sdQb6PR/zLY83QxeFilZmfpIl420DLfsqBtKp6AOaUKJ8Nk6gqk8v0xk+mcPL0LtPtRNckCRbAd9u4yusxEntGpoGboaNcaXhNtaSU5b3e8TF/IArMS42/IzDz6rRKfEH66VvM1NJdx9xV3/030OnuVJ/NBdu4ZlfMh89935cHpLPDHDRfTMPPzmxG0m9DIMjinvSuU4im19yUTS4tcx2HUiWVyqcDCkjrUdDMAHQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 23 Feb 2023 10:29:22 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 22.02.2023 13:00, Xenia Ragiadakou wrote:
> Do not include the headers:
> asm/i387.h
> asm/hvm/trace.h
> asm/processor.h
> asm/regs.h
> because none of the declarations and macro definitions in them is used in
> this file. Sort the rest of the headers alphabetically.
> Fix build by including asm/i387.h in vmx.c, needed for
> vcpu_restore_fpu_lazy().
Nit: You don't really "fix" the build, you keep it working.
> Signed-off-by: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
In principle
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
but ...
> --- a/xen/arch/x86/include/asm/hvm/vmx/vmx.h
> +++ b/xen/arch/x86/include/asm/hvm/vmx/vmx.h
> @@ -19,14 +19,11 @@
> #define __ASM_X86_HVM_VMX_VMX_H__
>
> #include <xen/sched.h>
> -#include <asm/types.h>
> -#include <asm/regs.h>
> +
> #include <asm/asm_defns.h>
> -#include <asm/processor.h>
> -#include <asm/p2m.h>
> -#include <asm/i387.h>
> -#include <asm/hvm/trace.h>
> #include <asm/hvm/vmx/vmcs.h>
> +#include <asm/p2m.h>
> +#include <asm/types.h>
... can this please become xen/types.h (and move up accordingly), so
things won't break here when my further work in that area lands?
Jan
|
