[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/9] x86/svm: move declarations used only by svm code from svm.h to private header
- To: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 23 Feb 2023 11:24:38 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RdPmr0Ymv7jB+hbnKCLpkii4YUjDH6O4FoQfspvTSgY=; b=RTJRuhh2vmlsDy6vLZulPvwjBYCAkvSfEIK1565UH/q6YQFKsNQbwhCjVRk2kj1szh6qfwR0uvNQeaJCU316W4hbG28zp+a1QnDYU4Q4t0qVcYsoP60KYs3nzCi4LQlY9pxdALrZS/EOSxY8r/XNSwGE3za56r40+GvHfuhqy93QJyosqePFF41Mpfm1DuaMjKdfvE+AewHVZInQWuJ+CT5Wgrx3HTlMAYAyBFISYORKS46ZfV246o+TIdDj9QunQE66U4bQhQAoLRCg1oa3XzysIheqPN23ZR2UKbwKT0u4q8pSp0sbPdiTFaRf2VNdst2lwQtMv8/vATR7uLpEhw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ld/5+dwU0/TSqRB+1VtEPy+HpPUhfrIZu8GHw03uV+2we7bBj3CZP1NF6pkdgN/8TWfc4YemDPZhV8OeSGhnMMP/ljZmT/fqjskZ9yxI3KtNimHVbH/lBcQdO4Daf0DUZspYlj7YmLUIcB1BPKhCPasts2yw5EbpmZlrUBarbI87EY6A1ttozasN8rDRLXaclGMzRsNUO2w9XZm0oJmNpNMu1Fi8MJUxl+kSRntl+H87D+2eKPRIZBa6e3ZZ3uSpLdzmFQB+zyOH9KtgmNydrkk9/fckKm6JTDQjEu0HFhrOjOH2hdcKX4Y+m8b2PBOF9WJeig9byAwUfak+gJ4tow==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 23 Feb 2023 10:24:57 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 22.02.2023 13:00, Xenia Ragiadakou wrote:
> Create a new private header in arch/x86/hvm/svm called svm.h and move there
> all definitions and declarations that are used solely by svm code.
>
> The function svm_invlpga() stays in arch/x86/hvm/svm/svm.h because it is used
> by arch/x86/hvm/svm/asid.h.
>
> Signed-off-by: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> Changes in v2:
> - new patch, the creation of a private header was suggested by Andrew and Jan
Same remark here as on patch 2.
> I have not added #ifndef guards as it is a private and it should not be
> included by other headers. However, this is considered a MISRA-C violation
> ... I 'm not sure what to do.
Personally I prefer the guard-less form, but since Misra insists, we may
better add them from the start. Besides being a little bit of clutter they're
harmless, after all. My ack stands with or without the addition, but I
wouldn't want to add them "while committing". So I guess we want to wait a
little for further views, and then either commit as is or wait for a v3 with
the guards added.
Jan
|
