[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen: Remove the use of K&R functions
- To: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Thu, 16 Feb 2023 23:17:50 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Xf25VlnnNv1fszSb5sncly0SRB1jltSI/r7xw4S63+A=; b=kjbEuFGsWayn11SXWq6LjNRPFvlcTkKE0gLxAdZwXaGI2hP0sThqzZN1SktcNV8E+J8fg3vZ8sLOl90Rmhlig57rErzq/daNO5PZdO+Jv7nTEcCof8TvrTOcbLpLqx+NWa4eJDl7zTuIFyuRe2j1D1UBuSrejFvt7cRr2yOTJFXzEl8VlDf2buFcC+ea6qqmVibdHWmMWCeOCCXFVP+CIvzckCkOCTmkoxiZquuvEaVUTf02M6aryLh7qpjU4SAN3aXmmjLhxNfeGpX1Y5ceWfOkgRyUf+BZyAiXAxDZGoqWE9wBsqYP9Lm+xeqGfdse/IGBTkcGRK1Frq/fmZKi8Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mxUHMiE0DjCwFF2401odZKcMSVxnZsIBdN2pDAkaN39ZPd5YJRpi7QFL+7QBclV0Ahes18vZDuGIk4GUot2D5A5x2/k/y9ErjJmKuiNnEdjv8SGtHiM9fE+Nv1ql0E2SrXq/hjRiHtbzvxLsA1t1yGAkvo1R/9lmDNMG9iAV8EJd+7dU/0tlki4MRJkA07p6qV4jeLVIJii9VIKfRrkJl9pkNPUctGnNFsm0y1QouFAICR/rtF1yr/9Y34c8zlG72idibAzEF0R77eIOVIkxHCIOlneKIKhLrqvyDG64fb7k6jeUJGZ30ERGqf61nP9OLZn6woH0CTb2W0hStwXmow==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Jan Beulich <JBeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Thu, 16 Feb 2023 23:18:19 +0000
- Ironport-data: A9a23:YLUCQa5cLrKTuUEiA88CpAxRtBrGchMFZxGqfqrLsTDasY5as4F+v jFMUDzUPfyPazf8ct1yPYzg8B4Bv8eAmNJgSVZu+S40Hi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraCYnsrLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+45wehBtC5gZlPaoS4geF/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5mz vUEBwBRaTO5uriY3q34dPVQvu8OI5y+VG8fkikIITDxK98DGMiGaYOVoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6MlEooiOKF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNNMTufoqaMy6LGV7jwyGTZVVkOjmPywjF6FcdIEM WsRxgN7+MDe82TuFLERRSaQsHOC+xIRRddUO+k78x2WjLrZ5R6DAWoJRSIHb8Yp3OcUbzE30 l6Cn/vyGCdi9raSTBq16bO8vT60fy8PIgc/iTQsSAIE55zppt41hxeWFtJ7Svft1JvyBC36x C2MoG4mnbIPgMUX1qK9u1fanzaroZuPRQkwjunKYl+YAspCTNbNT+SVBZLztJ6s8K7xooG9g UU5
- Ironport-hdrordr: A9a23:zeeRCq7S1SMh1VtIQAPXwD7XdLJyesId70hD6qkQc3FomwKj9/ xG/c5rsyMc7Qx6ZJhOo7+90cW7L080sKQFg7X5Xo3SOzUO2lHYT72KhLGKq1Hd8m/Fh4tgPM 9bGJSWY+eAaWSS4/ya3OG5eexQv+Vu8sqT9JnjJ6EGd3AaV0lihT0JejpyCidNNXB77QJSLu vg2iJAzQDQAUg/X4CAKVQuefPMnNHPnIKOW297O/Z2gDP+9g9B8dTBYmKl4is=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 16/02/2023 11:02 pm, Andrew Cooper wrote:
> On 16/02/2023 10:44 pm, Andrew Cooper wrote:
>> Clang-15 (as seen in the FreeBSD 14 tests) complains:
>>
>> arch/x86/time.c:1364:20: error: a function declaration without a
>> prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
>> s_time_t get_s_time()
>> ^
>> void
>>
>> The error message is a bit confusing but appears to new as part of
>> -Wdeprecated-non-prototype which is part of supporting C2x which formally
>> removes K&R syntax.
>>
>> Either way, fix the offending functions.
>>
>> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> ---
>> CC: Jan Beulich <JBeulich@xxxxxxxx>
>> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>> CC: Wei Liu <wl@xxxxxxx>
>>
>> These are all the examples found in a default build of Xen. I'm still
>> finding
>> toolstack violations.
> Apparently not. int cf_check vmx_cpu_up() too.
Ok, finally got a clean Clang-15 build. I've folded this hunk into the
patch:
diff --git a/xen/arch/x86/hvm/vmx/vmcs.c b/xen/arch/x86/hvm/vmx/vmcs.c
index 09edbd23b399..e1c268789e7e 100644
--- a/xen/arch/x86/hvm/vmx/vmcs.c
+++ b/xen/arch/x86/hvm/vmx/vmcs.c
@@ -781,7 +781,7 @@ static int _vmx_cpu_up(bool bsp)
return 0;
}
-int cf_check vmx_cpu_up()
+int cf_check vmx_cpu_up(void)
{
return _vmx_cpu_up(false);
}
but am not intending to send a v2 given how trivial it is.
~Andrew
|
