[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen: Remove the use of K&R functions
- To: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Thu, 16 Feb 2023 23:02:30 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PhOe6FXKu+Cni5AEKMew4GNelTLHcuzr1v3BhAjYkzs=; b=Dn+r1oNRBYV2AZyearqzC661ZTJg/fbqkTv4qft6PhE71ySSFdsFoP7yLYzmuRuL2u5/wQKklYpteL9wTIruBuEsaSDgLkzOA8Ls5O9FidjHkE8r4wQvAYB2mtO8+vkF3UcJVEvfCPHg9k0v6N6S+QjaNhUlSQz1fSNNtNqgcqHjI5O2+ipOzvoT/iBbTbWbwLwkKNlL7B0E635NaeVU+x46ukpATwxS1GY29ka3dVTyzsjfa1fixPXCIxM97vKl+5hi5/hI86JhYmDi7ioItkD9KTXcnd1V7Sr+/+klcb43KqiZdC9cS3ZGSTff+qomorZApPtnTX08uBZoBAIDlg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fEHY+Hds1F79GJRjKS9jYPv5+DxN5ukm8kVqbzjbs6qXT7sbbAA+9wV6dAehIDI5H7sIM8gvVgFAdI/NcyjJ+sni5YRN5F2w2J9H97P23ZrV+bCTo/QsNG59DpklGAwEEjxU4Xg1dvSFRAaDs4iPn1oZy/71EXymb30IgW5r9avNGxMAhp3PeWkDxqvL+rQJV9WWBElkm2PibXa8M0elNl9YtwN7vPSv5irKLO17Sd+84ZWvD7dsq23BjPdpVUGthN3T7LFSaqUVM5bkY5cU+ZJV5YSHNVqJBbOn9mF6gytCFwIujAtNgl/zfjw66cwycqOAD6wNR0aBNcgVU/G6BQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Jan Beulich <JBeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Thu, 16 Feb 2023 23:03:26 +0000
- Ironport-data: A9a23:A8K2SqBr9ADQ3xVW/wTiw5YqxClBgxIJ4kV8jS/XYbTApD8jgmYOm 2NLXGDUPqqLMGLxed9waIXi905X68XUnNZlQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtMpvlDs15K6p4GlB4ARlDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw5+B7Lz5P+ echdTUXZTqZpNDpmLO4Vbw57igjBJGD0II3nFhFlGicJtF/BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI++xuvDO7IA9ZidABNPL8fNCQSNoTtUGfv m/cpEzyAw0ANczZwj2Amp6prr6QxnKjCNJMfFG+3qR30R7MnFQ3MhdVdHSwmcnml3GEBPsKf iT4/QJr98De7neDXtT7GhG1vnOAlhodQMZLVf037hmXzajZ6BrfAXILJhZjQtE7sM49RRQxy 0SE2djuAFRHr7m9WX+bsLCOoluP1TM9KGYDYWoPSlID6ty6+YUr1EuQFZBkDbK/icDzFXfo2 TeWoSMihrIVy8kWy6G8+lOBiDWpznTUcjMICszsdjrNxmtEiESNPtfABYTzhRqYELukcw==
- Ironport-hdrordr: A9a23:221ylq3H0t9cCyengDZqRgqjBKMkLtp133Aq2lEZdPU1SKGlfq WV954mPHDP+VUssQ4b6LK90cW7L080lqQY3WByB9eftWDd0QOVxepZgrcKrQeAJ8T2zJ856Z td
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 16/02/2023 10:44 pm, Andrew Cooper wrote:
> Clang-15 (as seen in the FreeBSD 14 tests) complains:
>
> arch/x86/time.c:1364:20: error: a function declaration without a
> prototype is deprecated in all versions of C [-Werror,-Wstrict-prototypes]
> s_time_t get_s_time()
> ^
> void
>
> The error message is a bit confusing but appears to new as part of
> -Wdeprecated-non-prototype which is part of supporting C2x which formally
> removes K&R syntax.
>
> Either way, fix the offending functions.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> CC: Wei Liu <wl@xxxxxxx>
>
> These are all the examples found in a default build of Xen. I'm still finding
> toolstack violations.
Apparently not. int cf_check vmx_cpu_up() too.
~Andrew
|
