[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] build: Make FILE symbol paths consistent
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
- Date: Wed, 15 Feb 2023 10:15:10 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=FXTIAPOtl/XbORweWodUC/OPkWFve7kb1hadOq/CKq0=; b=M6GXZNLQYnznM344PYVf5NzKaphl1v3apSy8yD4HbSpXUcVAwBlQN17yyqtNmv080x/WrJ5H/IdKBD0ay5LDREHBG0dNO0dnpZjVRjb1KEkFqk1bLpJzcUhm1THsbAUIj0Ugk75AtslpkGB5dDPHmIYxFiAnKcngTx5atNWHIdC3hsOoUMUe6s3atPqgYtMDFc5x4sIYNHc7Uy2R0EXSkaE/OWP0e1mYKJydahEuoKVXNw4eTJED6royG5FzpD5x0/7dy6Zrovk46dw3PpLvdTg9+1qSEzlc38JoUauY/wq3o6epizIc9evFlVPV0JIdjvZVqJ9S+gg4vTpDRO8epA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T28iidTZYGtxgLxafa6hNg/IPvkbsmH6Kh5Ba0KZKM/1Kq2C8YLFgt4mgNRvPU446uveZ7XoCS5rWwfdqEfCdpnhna7kVUTSIQa0+ofzx1KzhHgMlNqObYsNyXXwHIfYw88twEqamrHYUwCYAj1JM4EbVGhn7CbdFGp5lb2Bdj4UC4Om1YGH2jhjkROxhU7zSQQPzjyyMMfiQ8KPxIXIZD788yni4gjPNc0rhko73z7EUXtqf3b4sOJ0sPjvHXwHI4OZVqMGJzgwG4Kxx6f28EBZytr8pwYKOCekiQv5jZ7svc6wTemC8StTKMNPRB0BE9V2mYRDu5QTpdBPJtw5NQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony Perard <anthony.perard@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 15 Feb 2023 10:15:39 +0000
- Ironport-data: A9a23:uGgvP6CosHJRkxVW/+Liw5YqxClBgxIJ4kV8jS/XYbTApDIq1zUCx 2ZMW2zTMv+CYDf0fIgnPduz8RkH7cTVmINmQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nOHuGmYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtMpvlDs15K6p4GlB4wRnDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw3ut7X1hx8 tYiJjFSVhev3eHswrCmVbw57igjBJGD0II3nFhFlGucKMl8BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTL++xruAA/zyQouFTpGMDSYcfMQcxak1yHr 2bC12/4HgsbJJqUzj/tHneE176SxnOmAtp6+LuQxu5V0EOznTUqOAAMRUr4k/q6jAngVIcKQ 6AT0m90xUQoz2SpRNTgWxyzoFafowURHdFXFoUS6hyJy6fSyxaUAC4DVDEpQMc9qMY8SDgu1 1mIt9DkHzpitPuSU3313qiQhSO/P24SN2BqTT8JS04J7sfupKk3jwnTVZBzHaitlNr3FDrsh TeQo0ADa647iMcK0+C+4grBijf1/JzRFFZpvUPQQ36v6R5/aMi9fYu05FPH7PFGaoGEUl2Gu 3tCkM+bhAwTMayweOW2aL1lNNmUCzytaVUwXXYH80EdygmQ
- Ironport-hdrordr: A9a23:Ohibx666YQzrUnCiUQPXwMvXdLJyesId70hD6qkXc20wTiX4rb HKoBx4vSWftN91YhwdcL+7Sc69qB/nmqKdgrNhX4tKPjOHhILAFugLhrcKpQePJ8SUzJ8/6U 4PSclDIey1KWJa5PyX3DWF
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Msip_labels:
- Thread-index: AQHZP8wQAlEMPw7YZkelXrHFvRoSWK7Px5eAgAADTY8=
- Thread-topic: [PATCH v2] build: Make FILE symbol paths consistent
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: Wednesday, February 15, 2023 9:55 AM
> To: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
> Cc: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>; George Dunlap
> <George.Dunlap@xxxxxxxxxx>; Julien Grall <julien@xxxxxxx>; Stefano Stabellini
> <sstabellini@xxxxxxxxxx>; Wei Liu <wl@xxxxxxx>; Anthony Perard
> <anthony.perard@xxxxxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx
> <xen-devel@xxxxxxxxxxxxxxxxxxxx>
> Subject: Re: [PATCH v2] build: Make FILE symbol paths consistent
>
> On 13.02.2023 17:55, Ross Lagerwall wrote:
> > The FILE symbols in out-of-tree builds may be either a relative path to
> > the object dir or an absolute path depending on how the build is
> > invoked. Fix the paths for C files so that they are consistent with
> > in-tree builds - the path is relative to the "xen" directory (e.g.
> > common/irq.c).
> >
> > This fixes livepatch builds when the original Xen build was out-of-tree
> > since livepatch-build always does in-tree builds. Note that this doesn't
> > fix the behaviour for Clang < 6 which always embeds full paths.
>
> Is "fix" here actually correct? I.e. is there anything to fix in that
> case? It looks to me as if "always absolute paths" is as good as
> "always relative paths". In which case s/fix/alter/?
>
If embedding absolute paths, the livepatch-build process will fail to
match symbols between the base xen-syms and the newly built, patched
objects unless they are built with the source directory at the exact
same path. So yes, I would consider this as not "fixed" for Clang < 6.
Thanks,
Ross
|
