[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] build: Make FILE symbol paths consistent
- To: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 15 Feb 2023 10:55:11 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=91Bht+PFAiL3+dnjnzHNZY9YouHjXxh9o1B48Sjr7tE=; b=Dw+baUHFfw0lzbNOb8qTwvXJURkQspxICj2KxmqdORq9oiwZF6PRN9RA0z3nXmJudwYKgeufLffemlCbgcYiOheqmfGLB21R5ABpbTDSewu5XFkVziLIdK6JBv5XBEDNs4Wmr+zW5t5Zx7jGWg6pQC+DEUIhqoul6mgbdYT6fH2cZ4xrBbROOPv9knCPDg22+FDng5Rpq2gOcSGVydestwUw0Xd4Rb9wobpbM+E7H9JH2jsD3KSLo7NEq1xuulVseYkv0emt9RLZY/Adq01Pl98QdF/IThhn621mhsaF/unq/J3vHG2VLfRjoIMbOnH4jokTsGmz60DVXEgLoLt94g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LtXJ2mPCRzWj6bWU8xcsLrg1valq+mUr/uZCO47D6jSFXSVjOK06YD0mQv/Jo5egx+UtSJlbSKVg2fraV2l0f2oxGdVqWJuSiyRIUk38lqAmsuCLEtd84OCJnbaB8bDv+cLmGyLj1E/BllpPwWKS02L6lkoSDcd+1a5VfiiJM6X0igi4lemx96zaGDMuyEcWJsjkFyDJ94VQOUZ9S9do4IvDyuLAwump9YEDB+50nwFYlbEfhQqyx/pqcjTsMESOE0BmtKOh/Wh08hQ5LwcZ80HJieHj9ylC0r6wjgx+ICS44HC9nmFP6c193bz6tW6jAicr9Sd7V1u16xaTXuOjMQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 15 Feb 2023 09:55:30 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 13.02.2023 17:55, Ross Lagerwall wrote:
> The FILE symbols in out-of-tree builds may be either a relative path to
> the object dir or an absolute path depending on how the build is
> invoked. Fix the paths for C files so that they are consistent with
> in-tree builds - the path is relative to the "xen" directory (e.g.
> common/irq.c).
>
> This fixes livepatch builds when the original Xen build was out-of-tree
> since livepatch-build always does in-tree builds. Note that this doesn't
> fix the behaviour for Clang < 6 which always embeds full paths.
Is "fix" here actually correct? I.e. is there anything to fix in that
case? It looks to me as if "always absolute paths" is as good as
"always relative paths". In which case s/fix/alter/?
> Fixes: 7115fa562fe7 ("build: adding out-of-tree support to the xen build")
> Signed-off-by: Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>
With the above clarified (a possible adjustment could be done while
committing):
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
Jan
|
