[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v4 3/5] x86/iommu: call pi_update_irte through an hvm_function callback
- To: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Tian, Kevin" <kevin.tian@xxxxxxxxx>
- Date: Wed, 1 Feb 2023 05:11:52 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b+bBWUPbIBEuR2EhtfZsUh0jZolhdTF7A/ADX3h27Nc=; b=BgmDy6tTgUoC18RkbLpSN4YrpFoJ0paT22cWJ561DYN7IWfmULat8c9B8ME4dk+HJ3tyEIZGjdEUmz8uNa3N3eZ6RHWZiF7OTAQCkSAeH4CXPPnrJj7tpr7fvtSgCWBSAB/x3BBXbRKZGExy0keY8rGRwq2G7x4nU2WAAEOcfr0h1TQR7ZGEl7AAsJtz36s/dQm25vXCCkK7tdP3t+WHkRLNAeF1zf66WuUfv49g8J0F+WtQxYphzTWD/0TWTllglBlAQVsq1CZQTaLcBzJKV8y7ynV1FS7WGFOco8bUh+7oCfVuoiwFvfU5GEbw7FgULO4/Nhv8/Zevi6jvVZymFg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BkoBXURUBpQ+y2D+EHVyOpBN3shn6m5B8pUdBfCFAPT18P4sf7/HnElWpkQw1qKUaDSWnjw59K3EA0BxmM6ETB3VczhXfKoG4IP+j526slrA0+RurUW+xMqu9ZfZ7uufV7mRWgYDLvkE9WDEXoJcG/GdQNRMJ1jHjrqmQaWff1LJJv7kLdkUsUi3hprtu5UDUF13IQFWpJeLftR4w0FxjAJRDmcN380vNazgWJgMRwfFxPGENoDFM9lq8+lffMI8iLjyrL7gooVIGw16Kly1eXqt2o+YRjBgwsHYbnQonDKKRXSMLfGkK6CO+98e6m5clzQVsxOjBAxlHIfoymt00A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com;
- Cc: "Nakajima, Jun" <jun.nakajima@xxxxxxxxx>, "Beulich, Jan" <JBeulich@xxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, Pau Monné, Roger <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Paul Durrant <paul@xxxxxxx>
- Delivery-date: Wed, 01 Feb 2023 05:12:08 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHZL/FBdWHP+udJ1U++j3LNg3bXBK65l2Zw
- Thread-topic: [PATCH v4 3/5] x86/iommu: call pi_update_irte through an hvm_function callback
> From: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
> Sent: Tuesday, January 24, 2023 8:42 PM
>
> Posted interrupt support in Xen is currently implemented only for the
> Intel platforms. Instead of calling directly pi_update_irte() from the
> common hvm code, add a pi_update_irte callback to the hvm_function_table.
> Then, create a wrapper function hvm_pi_update_irte() to be used by the
> common hvm code.
>
> In the pi_update_irte callback prototype, pass the vcpu as first parameter
> instead of the posted-interrupt descriptor that is platform specific, and
> remove the const qualifier from the parameter gvec since it is not needed
> and because it does not compile with the alternative code patching in use.
>
> Since the posted interrupt descriptor is Intel VT-x specific while
> msi_msg_write_remap_rte is iommu specific, open code pi_update_irte()
> inside
> vmx_pi_update_irte() but replace msi_msg_write_remap_rte() with generic
> iommu_update_ire_from_msi(). That way vmx_pi_update_irte() is not
> bound to
> Intel VT-d anymore.
>
> Remove the now unused pi_update_irte() implementation.
>
> No functional change intended.
>
> Signed-off-by: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>
|
