[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v2] x86/shadow: make iommu_snoop usage consistent with HAP's
- To: "Beulich, Jan" <JBeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Tian, Kevin" <kevin.tian@xxxxxxxxx>
- Date: Wed, 1 Feb 2023 04:47:28 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kFjD2zj6aJjG+o2lSli+t3S8WH0BY1DmT6LK2G+iY7I=; b=fUOFGey2naTP/hYEXNlq/6tQIOzRmdY/IlUXC+U5SZa01OEyubWd4fgexZFo1nHvl95GvJyzGSLEV7lEyOWTtI7BqFnSjWzWeYOoM3FQ38oqRlpiFCYCl1YZm8reJF+mlpzYNIESGb4PIGG+Bi9h+qtbVWJqNX7l2i1YHzbr3pzJZp9e6F+f62qPIfxn939/QSPtOkl0+um3Lqh6LdMdRFq4+ssmL1PRvp+PBOcUQ7lvFhxi+Uk4NmFDEVwSEYwyohz7mqDZobH6kbElGl3129WuHgKrPRn5vDanzZWISx1wx8AtkrfjkQTAN/hZ8qPn92wh0sE/cRo5XRb6Cc8aHg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mxtGd0LCkkULl+/TZwzWbqAHZUbphv3olrnbeRS9w35n6XoQIA3U9G/FljUrMVRiG5WCD5fCZQH35WzflshyHZlKkPy/h6FPnNjINjj5W1kEsUq0QbwKSAJeNjdAE6gloT2oD5b3xEdgDFDICF5VuKFd+NEx6vlEwL/KkxzIQUY3zhSaLYxv5K/jbGZOjki2aw8JYKAapmgC6QHPzsmKCobk/bFn6+db5mqqKLkH1ARiltEEyFY33juc82vt8OA4bWLsbZGDwnEBx7llkd49fb7wceqbWzWqyopHvGI15UVTNPmxHMENJ9rL3TMqJxiDadz4w4mvd+VbAyUfO6Mytg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com;
- Cc: "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Pau Monné, Roger <roger.pau@xxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, "Paul Durrant" <paul@xxxxxxx>, Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
- Delivery-date: Wed, 01 Feb 2023 04:47:47 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHZLKt8IVjqligRc0qxDetLKfU0DK65lxGw
- Thread-topic: [PATCH v2] x86/shadow: make iommu_snoop usage consistent with HAP's
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: Friday, January 20, 2023 4:44 PM
>
> First of all the variable is meaningful only when an IOMMU is in use for
> a guest. Qualify the check accordingly, like done elsewhere. Furthermore
> the controlling command line option is supposed to take effect on VT-d
> only. Since command line parsing happens before we know whether we're
> going to use VT-d, force the variable back to set when instead running
> with AMD IOMMU(s).
>
> Since it may end up misleading, also remove the clearing of the flag in
> iommu_setup() and vtd_setup()'s error path. The variable simply is
> meaningless with IOMMU(s) disabled, so there's no point touching it
> there.
>
> Finally also correct a relevant nearby comment.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>
|
