[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 01/22] xen/common: page_alloc: Re-order includes



Hi Jan,

On 16/12/2022 12:03, Jan Beulich wrote:
On 16.12.2022 12:48, Julien Grall wrote:
From: Julien Grall <jgrall@xxxxxxxxxx>

Order the includes with the xen headers first, then asm headers and
last public headers. Within each category, they are sorted alphabetically.

Note that the includes in protected by CONFIG_X86 hasn't been sorted
to avoid adding multiple #ifdef.

Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Thanks!


----

     I am open to add sort the includes protected by CONFIG_X86
     and add multiple #ifdef if this is preferred.

I, for one, prefer it the way you've done it.

Ok. I have committed the patch as-is .

Cheers,

--
Julien Grall



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.