[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 01/22] xen/common: page_alloc: Re-order includes
- To: Julien Grall <julien@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 16 Dec 2022 13:03:44 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9jBQQfV3y3t9fT4po00CZXGlbfolHm9ylOQK4hGj1ik=; b=GqTIPm72i9YkwOkOPpd2i/TC5xinwnrUqqFK9Qvace7Q26DCEC2Uj0YhWGz/t1fEahg3Wrq7Bhw3xjJogh95JUAIJrYyFW/OzxNRSUMQhn/t6umJfEY4mSIuhAmGqJtq8oZy6K4ONe6jj5dOGUtlu+FwOBwFF1BW8hvT9a9FomC//9eGK/k5NVkag8zIsO6dZOxVnG+4i7f/1YlUhzJspLnO6mAVKP4htMwpgqB+urNqcie51kvDB6aeWoxSy4PyQ8L4amyt4yBBePQxTwfa7PsrIHeGspq+qgY5sF3/2YjoDPsbvC4ulROkfg48EaK+zDx6XuVmvkDJKTwPawG/6A==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oR+OKNaVhjVlFAW4DQZbYUzLTUqSsnwXxcT9F5YqQ8w96J3LsjhasiCcnwinWn6sMeI+/k/TVxCXdcKAuT1am2BWy8u2m3xJH1+X1hSGANf5RCBX6QMMBpM73fYu/w5+tsJ3G906TPgXq5jHqiHGKy9VyZY3EnXhJUAXv/kBF+zaiQ8G8+VNQIe9Rgz9NzCOrhjeirfyx4p5UpcgJyAtEjry7CoFF1GCAPU1tz03TK8HGV6C7J0Jb7CG/ubOozQjesWVWK4ZXM1Q4RqBXoSC31jqHHogYNRA/iYhRTddPc0OGGQuVrK4nIdKt/py+foZsPbqn0RglxYXfiGpLgJSmw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Julien Grall <jgrall@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Fri, 16 Dec 2022 12:03:54 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 16.12.2022 12:48, Julien Grall wrote:
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> Order the includes with the xen headers first, then asm headers and
> last public headers. Within each category, they are sorted alphabetically.
>
> Note that the includes in protected by CONFIG_X86 hasn't been sorted
> to avoid adding multiple #ifdef.
>
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
> ----
>
> I am open to add sort the includes protected by CONFIG_X86
> and add multiple #ifdef if this is preferred.
I, for one, prefer it the way you've done it.
Jan
|
