[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC 6/7] x86/iommu: call pi_update_irte through an hvm_function callback
On 12/21/22 12:13, Jan Beulich wrote:
On 19.12.2022 07:34, Xenia Ragiadakou wrote:
@@ -774,6 +779,16 @@ static inline void hvm_set_nonreg_state(struct vcpu *v,
alternative_vcall(hvm_funcs.set_nonreg_state, v, nrs);
}
+static inline int hvm_pi_update_irte(const struct vcpu *v,
+ const struct pirq *pirq, uint8_t gvec)
Why "int" as return type when both call sites ignore the return value?
Because the original function returned int. I 'm not sure though why the
returned value is ignored.
@@ -893,6 +908,13 @@ static inline void hvm_set_reg(struct vcpu *v, unsigned
int reg, uint64_t val)
ASSERT_UNREACHABLE();
}
+static inline int hvm_pi_update_irte(const struct vcpu *v,
+ const struct pirq *pirq, uint8_t gvec)
+{
+ ASSERT_UNREACHABLE();
+ return -EOPNOTSUPP;
+}
I don't think you need this stub - both callers live in a file which
is built only for HVM=y anyway.
That's true. I will remove it.
Jan
--
Xenia
|
