[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC 6/7] x86/iommu: call pi_update_irte through an hvm_function callback
- To: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 21 Dec 2022 11:13:32 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sxHLnB66cKtWFyV8NxlthOE17z+vwATgZeHTVQZC2S0=; b=lk5RjJnWOWwKta0EHMHGYudC1n/YkaGzTGt5AshE+el6jQWe46k7fhX0+WCrhdoWqF4wWQLEksV7M6PfSLgwtddVamsT0F2RW4PRR/a1wnxDOHmioUN+r7AcKaO1vyr5/Q9N62eA8UwRC/LROQtHpu14hFpnbbuqLfuSWm77pJZjGk6Om9rpz4gpBz7OAgO0moxF2c9qoq91WQudzpDC9xhTtMiGZE+vRLFarshRn4v7V8ZpA+a4lfZCskJtfIRWJ1YhpsritV+eFTHmNRORJ0crE+0PFeegd5+2O8u8JMq0aOoOfNVXTHTbYG0mNNMdsiWb/wN3tvD4yB0GCdmLVw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CLLYjkZXJN1Zg40bVvtpTjKhlcyv7hc8a11VygaZGgUxnHfRk3J8x8Vk2atG+gBqwPVB/761pnnPn6tzxTLe8OSkuNM8XK11Ps3Ek6stA1c53/gZzpR4KaSH3+SwkkqEiVcnfw0f3xqtxcpbgKDywszS/Bc+Y4HD7QU49vH3xaKyIIpx2/KBfQhBlYJT9ebNAoCpzYamRuLzt6n1fdeEXCr8hNgd8gTcGeGMscYaMqNLwQ+KgKm1VgZzuGshlzuc8fK+W9cBbukLCD+WEFuaoPle/kY1r1Fnumm7dPVHTdzGfbHRt+OvxpX/zCDqxeodfpSoWShcbrIFIHVweH4ZhQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Paul Durrant <paul@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 21 Dec 2022 10:13:44 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19.12.2022 07:34, Xenia Ragiadakou wrote:
> @@ -774,6 +779,16 @@ static inline void hvm_set_nonreg_state(struct vcpu *v,
> alternative_vcall(hvm_funcs.set_nonreg_state, v, nrs);
> }
>
> +static inline int hvm_pi_update_irte(const struct vcpu *v,
> + const struct pirq *pirq, uint8_t gvec)
Why "int" as return type when both call sites ignore the return value?
> @@ -893,6 +908,13 @@ static inline void hvm_set_reg(struct vcpu *v, unsigned
> int reg, uint64_t val)
> ASSERT_UNREACHABLE();
> }
>
> +static inline int hvm_pi_update_irte(const struct vcpu *v,
> + const struct pirq *pirq, uint8_t gvec)
> +{
> + ASSERT_UNREACHABLE();
> + return -EOPNOTSUPP;
> +}
I don't think you need this stub - both callers live in a file which
is built only for HVM=y anyway.
Jan
|
