[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 17/18] public: misra rule 20.7 deviation on errno.h
- To: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 21 Dec 2022 10:25:21 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Afbr0GHsM6eA05h7aH4WcjeitjCtOQBtgPnVt9trW0c=; b=PUbumzQT94+mBtjMADnDFIV7Lb0sPN6eCMsuceMLZyhFZ9p6E2XsNod7r3CneFJyDGjwC566voMrySou26LhytHiDhn80pMejyAUfNhuOEVM7hV1srhmM8RNTVgYlLretQKe+dzSR6n5QbHedMxhJg0ZYTAetGBYWuv+ESWeVhG01TnuPI2XGuLZjSKqNhnUPwP8uF0l0cZOHv/gSl7hqC4u9SOIVniSxr6QMp4ReI4Kj3qqERdt6MOcKDo2zY+x7lPaj/6mi9nIeZnY6FM97RSG89NzMOOCz7EcvXxfFVXUB2zbMkUja3Rbir6AbRt7ZG8rAzVCUsRsDtx0+AAmkw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ac4Mv8aYixo6cY0bQAnILQ2ot8zAJgcnj+RIhX6rCP4RVoGlhqjdnqwx0nqEfkf+oZl+xjzACd3jy8vOkDOUaC9AvK1ftVn2xSNpP8fRDVT6+mkM+VGNBwUrbkg6QK57MrfGzW6csuliD+wXZUjX5cdl6pGQXVP2YkXkwr1qJoH+FVp1XbtDtQF0eO4WilQU18bNQH80A/xOUbshB01VMKqpY23kTYfH4Jsv5UmQSYqE9TWl4PfrW9DSw8FZATXy6EoTJyydmPDZeVtsdDIda6YqTCW4qZ++N2+0GIpAwjIxYpBesV/xhHGDJYFWek2dbrufvk0o8crXqIc5lF6e+A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Wei Chen <Wei.Chen@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 21 Dec 2022 09:25:44 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 21.12.2022 09:46, Luca Fancellu wrote:
>> On 20 Dec 2022, at 09:51, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>> On 20.12.2022 09:50, Luca Fancellu wrote:
>>> Cppcheck has found a violation of rule 20.7 for the macro XEN_ERRNO,
>>> while the macro parameter is never used as an expression, it doesn't
>>> harm the code or the readability to add parenthesis, so add them.
>>>
>>> This finding is reported also by eclair and coverity.
>>>
>>> Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx>
>>
>> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
>>
>> But with the title adjusted - this isn't about a deviation, but actually
>> addressing a finding.
>
> Is it ok this title:
>
> public: misra rule 20.7 fix on errno.h
Sure.
Jan
|
