[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 17/18] public: misra rule 20.7 deviation on errno.h
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Wed, 21 Dec 2022 08:46:07 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=F89N1bOr0Wx/OsmP4nIOjqrWOw7O5CLxqilM7ntPwlI=; b=W+Nari0Cn9aS5zAF9Wr84lO8+GN8rhYNKKS3dUHUaGwzzzcnBM4WKOpr6aIsa13m74myhIVIq/HXJzSCxpFg53A7UqiHnSlII5AmgdK8ssxLreqyMHzbkRj7L6MB0WcpVbVNN0gbuF4Box+0TrjrfGGyKP6CCyX01PhqcW86gX7mgVcI8qlmDeZKk3+tXlsPghf3DtlGPxumwgKfTJoVOeV9Hcq9d0KWgdITcCJBRCEmrz9LDjkHt0pwB31xqesloAiiiF9oH0YNSHqNTpduNEHhjMUC54/jjGwOTaEkQ4CpQWhe6Z38j0Z9qSUUNoTO4AV3P9/X4dOmM7siEZUvFw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E6uB96XuPzNO6D2Y3Rk+NqxnsvuPPIlVJiWMUrz95Ce98doebunb4eUhjN0SMr4B6G+3u72/E5mmGq34+TZW4qjgkCxZC9nRbBk9+PgdLDY4PlTDe8pyllb6Hi3fKgx3hgmmp9Xq8khyHi8NHS4rWhdzyL7r+sXO7mCOpnMzKI45D3H0K8i9/9B39e1jI3aMzmTUhkNZOnW5HL/BoPVuTdX0PQGFkIoSmPeGDz2pTIsfWSSgpRptpHAuPgiDYj3JKpPD6WTEXWs5c9yqHjLn2N9XfgZAcCvgnk6rOJkDtqKYNF7uKTceZWoI++BryIy4gEm13h0/0D9dfHJlr0CbOw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Wei Chen <Wei.Chen@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 21 Dec 2022 08:46:37 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZFFDT1G4dt8FOrUCfFOSy+7FsQq52iJ4AgAGACAA=
- Thread-topic: [RFC PATCH 17/18] public: misra rule 20.7 deviation on errno.h
> On 20 Dec 2022, at 09:51, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 20.12.2022 09:50, Luca Fancellu wrote:
>> Cppcheck has found a violation of rule 20.7 for the macro XEN_ERRNO,
>> while the macro parameter is never used as an expression, it doesn't
>> harm the code or the readability to add parenthesis, so add them.
>>
>> This finding is reported also by eclair and coverity.
>>
>> Signed-off-by: Luca Fancellu <luca.fancellu@xxxxxxx>
>
> Acked-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> But with the title adjusted - this isn't about a deviation, but actually
> addressing a finding.
Is it ok this title:
public: misra rule 20.7 fix on errno.h
>
> Jan
|
