Re: [RFC 2/7] x86/iommu: amd_iommu_perdev_intremap is AMD-Vi specific

[Xenia Ragiadakou <burzalodowa@xxxxxxxxx>]

On 12/20/22 12:31, Andrew Cooper wrote:
> On 19/12/2022 6:34 am, Xenia Ragiadakou wrote:
> > diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c
> > index 5e2a720d29..1a02fdc453 100644
> > --- a/xen/drivers/passthrough/iommu.c
> > +++ b/xen/drivers/passthrough/iommu.c
> > @@ -58,7 +58,6 @@ bool __read_mostly iommu_hap_pt_share = true;
> >   #endif
> >   
> >   bool_t __read_mostly iommu_debug;
> > -bool_t __read_mostly amd_iommu_perdev_intremap = 1;
> >   
> >   DEFINE_PER_CPU(bool_t, iommu_dont_flush_iotlb);
> >   
> > @@ -115,8 +114,10 @@ static int __init cf_check parse_iommu_param(const char *s)
> >               if ( val )
> >                   iommu_verbose = 1;
> >           }
> > +#ifdef CONFIG_AMD_IOMMU
> >           else if ( (val = parse_boolean("amd-iommu-perdev-intremap", s, ss)) 
> > >= 0 )
> >               amd_iommu_perdev_intremap = val;
> > +#endif
> See parse_cet() and the use of no_config_param() so users get a bit of a
> hint as to why the option they specified is getting ignored.
Ah, ok I see. Thx for pointing that out.

> ~Andrew
--
Xenia