[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC 2/7] x86/iommu: amd_iommu_perdev_intremap is AMD-Vi specific
- To: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Tue, 20 Dec 2022 10:31:31 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tfXPPr0o990M5PXY/eSQK6WrCqDBXjKrwv7/2THhOSM=; b=cy3BARtOwFeZEmazu/FbOeUt8A7RKacy29vA4gz/0CfWDXkhSkPg5c9iAurnQpsvP2FcvKh7/woizYsDcxFG7h1k9uAge22YfXZZ5rA8t7IMZFjttEbsxhnYOt8HEPtXyPFQK/h3Xt9BivUGWVF0sEMEwCoC9TIFIBLlbLccQzL4p580ZuylgDU68l8SbLgTdDFiHQ91LU4wEqefhjuIishPY1o3SX5D+K40HfAaB//f7qN0v9CllpiB1IGbJ/fVxyPWdXxwxwlZEpGPRo+t+kovpnqZtAmicvzHbhHsP0atgtSSJSKkAlNmtu52HkTvYEkChxnI87mMKC6udmhrtQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D5ucISsf4jk+BuizOZ9y0gvS7FSVWBUQv1uevlJY+ZBmbd7khmIKTTF2cc1vcc+C+JIPTo38f++TXQ+WjfzeGtWsjxM7KUV2ad1tqPPcVlKTAe1nB7ZmUfmj9o4KBQnvdTpT25XxCIUrybUkWCA0Ufqh81oMHn+ultoH+eYQ8FOeTzsn3EZD+yWfZ4uwKnp9SGKWgbMihLPXQV9H+ByZS/QUGJW7GTINg/QxmRjF7NIggaYXFZTZQNB5ue2+Tv1xyaAEDAZ40JO++BNW2t1/QDuB6SpY6zyBB4tl8YttuURzoFu0LaLRvXeZzoSzjMYVdC1/Vnrg+NzmLX3t4suYww==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>
- Delivery-date: Tue, 20 Dec 2022 10:31:50 +0000
- Ironport-data: A9a23:QEiN3aPn9qJoCqnvrR1glsFynXyQoLVcMsEvi/4bfWQNrUog0z1Sm 2RJUWrSPPbZN2Sjetp2bYrjp0IBvZWEyt5kGQto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQA+KmU4YoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9SuvzrRC9H5qyo4mpC5ARmP5ingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0s1qE3kT1 N5CERAUcUGojbq/3eq2ROY506zPLOGzVG8ekldJ6GiASNoDH9XESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PVxujeLpOBy+OGF3N79U9qGX8hK2G2fo XrL5T/RCRAGLt2PjzGC9xpAg8efzHmkAthJTtVU8NZ4rlO63Ek6TycbfnKRh/vjt2Cud8J2f hl8Fi0G6PJaGFaQZtPgRQ+xpHmIuQEVc9VVGuw+rgqKz8L88wufQ2QJUDNFQNgnr9MtAywn0 EeTmNHkDiApt6eaIVqf/LqJqTK5OQAOMHQPIyQDSGMt+9D+pKkjgxSJScxseJNZlfXwEDD0h jyP8i43guxKidZRjvrju1fanziru57FCBYv4RnaVX6k6QU/Y5O5Y4uv6h7Q6vMowJulc2Rtd UMsw6C2hN3ix7nX/MBRaI3hxI2U2ss=
- Ironport-hdrordr: A9a23:FlrbKqo1tD4fATOSfxcX1l0aV5tyLNV00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssSkb6Ku90KnpewK+yXbsibNhcYtKLzOWwldAS7sSorcKogeQVhEWk9Qw6U 4OSdkYNDSdNzlHZIPBkXGF+rUbsZe6GcKT9IHjJh5WJGkEBZ2IrT0JczpzeXcGJjWucKBJcK Z0kfA3wgZIF052Uu2LQl0+G8TTrdzCk5zrJTQcAQQ81QWIhTS0rJbnDhmxxH4lInNy6IZn1V KAvx3y562lvf3+4ATbzXXv45Nfn8ak4sdfBfaLltMeJlzX+0WVjcVaKv+/VQIO0aWSAWUR4Z 7xStAbToJOAkbqDySISN3WqlDdOXgVmiffIBSj8AbeSITCNU4H4ox69MNkm1LimjQdVJsX6t M140uJ85VQFh/OhyL7+pzBUAxrjFO9pT44nfcUlGE3a/pXVFb/l/1swKp5KuZ3IMvB0vFvLM B+SMXHoPpGe1KTaH7U+mFp3dy3R3w2WhOLWFILtMCZ2yVf2CkR9TpT+OUP2nMbsJ4tQZhN4O rJdqxuibFVV8cTKaZwHv0IT8e7AnHEBRjMLGWRK1L6E7xvAQOHl7fnpLEuoO26cp0By5U/3J zHTVNDrGY3P1njDMWftac7hSwlgF/NKQgF5vsulKSR4IeMNYYDGRfzOGwGgo+nv+gVBNHdVr K6JI9WasWTWFfTJQ==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHZE3QWS6NAJx0E4UyJylqsah2q1K52lYuA
- Thread-topic: [RFC 2/7] x86/iommu: amd_iommu_perdev_intremap is AMD-Vi specific
On 19/12/2022 6:34 am, Xenia Ragiadakou wrote:
> diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c
> index 5e2a720d29..1a02fdc453 100644
> --- a/xen/drivers/passthrough/iommu.c
> +++ b/xen/drivers/passthrough/iommu.c
> @@ -58,7 +58,6 @@ bool __read_mostly iommu_hap_pt_share = true;
> #endif
>
> bool_t __read_mostly iommu_debug;
> -bool_t __read_mostly amd_iommu_perdev_intremap = 1;
>
> DEFINE_PER_CPU(bool_t, iommu_dont_flush_iotlb);
>
> @@ -115,8 +114,10 @@ static int __init cf_check parse_iommu_param(const char
> *s)
> if ( val )
> iommu_verbose = 1;
> }
> +#ifdef CONFIG_AMD_IOMMU
> else if ( (val = parse_boolean("amd-iommu-perdev-intremap", s, ss))
> >= 0 )
> amd_iommu_perdev_intremap = val;
> +#endif
See parse_cet() and the use of no_config_param() so users get a bit of a
hint as to why the option they specified is getting ignored.
~Andrew
|
