[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Virtio-disk updates for latest Xen ?



On 14-12-22, 17:01, Oleksandr Tyshchenko wrote:
> Today I had a chance to check virtio-disk on my H/W using new Xen branch
> which does include Juergen's series with commit 3a96013a3e17
> ("tools/xenstore: reduce number of watch events").
> 
> Very interesting, but I didn't manage to reproduce an issue the similar to
> what you had already faced with the rust counterparts before (caused by the
> lack of Xenstore watches?). Note that I didn't debug what exactly events I
> had got during guest creation/destruction, I just made sure that backend
> worked as before. I checked that by running the backend in Dom0 and DomD and
> performed a couple of guest power cycles (reboot, destroy/create).
> 
> If you could provide the debug patch which you seem to use to print incoming
> events which you described in previous email, I think I would be able to
> re-check the situation at my side more deeper.

This should be enough to see the new changes I believe.

diff --git a/xs_dev.c b/xs_dev.c
index a6c8403cfe84..8525c6512299 100755
--- a/xs_dev.c
+++ b/xs_dev.c
@@ -421,6 +421,8 @@ static int xenstore_poll_be_watch(struct xs_dev *dev)
     if (!vec)
         return -1;
 
+    printf("%s: %s\n", vec[XS_WATCH_PATH], dev->path);
+
     if (!strcmp(vec[XS_WATCH_PATH], dev->path))
         rc = xenstore_get_fe_domid(dev);

-- 
viresh



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.