Re: Virtio-disk updates for latest Xen ?

[Viresh Kumar <viresh.kumar@xxxxxxxxxx>]

On 07-12-22, 05:51, Viresh Kumar wrote:
> I am not sure how to get this working, as there is no finalizing event
> for the directory. Maybe our design is broken from the start and we
> need to do it properly in some recommended way ?

For now this is what I have done to make it work:

diff --git a/xs_dev.c b/xs_dev.c
index a6c8403cfe84..4643394a52a2 100755
--- a/xs_dev.c
+++ b/xs_dev.c
@@ -413,20 +413,7 @@ static int xenstore_get_fe_domid(struct xs_dev *dev)
 
 static int xenstore_poll_be_watch(struct xs_dev *dev)
 {
-    unsigned int num;
-    char **vec;
-    int rc = 0;
-
-    vec = xs_read_watch(dev->xsh, &num);
-    if (!vec)
-        return -1;
-
-    if (!strcmp(vec[XS_WATCH_PATH], dev->path))
-        rc = xenstore_get_fe_domid(dev);
-
-    free(vec);
-
-    return rc;
+    return xenstore_get_fe_domid(dev);
 }

This rns xenstore_get_fe_domid() for each event in the path
"backend/virtio", and in my case it passes with the second event
itself, which came for "backend/virtio/1/0" and this code doesn't run
after that.

Note that I have tested this with my rust counterpart which received a
similar change, I didn't test virtio-disk directly.

-- 
viresh