[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] efi: Relocate the ESRT when booting via multiboot2


  • To: Demi Marie Obenour <demi@xxxxxxxxxxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 14 Dec 2022 10:34:27 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eWw5HH9xajBUKyQ7zeSCCSpXOdeoVqkj2/ya9fqC3tY=; b=kpDEo+JtuROvBu0JKKMiEhkIOK9N7eJ2u1s2fmyyh2NmKpxonni0qG21trVShJhPG+2Xyycj5yrj7cGRxIFwORmCWbrvEVlz/RCV+h+H8z8etZpZiJGTtFRjzjB26DBm49fl5yMePwghi9Ki8UutlcnK6S0grtAjI7kRMEdALQ05pBV9oDwCwO4ZukW8j/qeb+cOcuifAy53pCZVOHq4I9t6SbLE35LdjBIRYY34CDVMbUhK6YvNaGORpmoviOJdBR/PHbhHF0A13Aj5plu65QSQ/iXE/BgbG6hnekc627PWqW4qU+QChwBvAgHwOkB9gCZoFQlpz2NUFbgCZtGNBA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JkXHGHUgmQh0XpFjMJz3YYuJPN4YTSYQLFhpeZjVH5MiXTvWhsQ0oPfLZBFC1MrCYp6zzJ6P5mbJopc390Ec/nlJV+yzcSB2T0PaULtVte3M2t8LPFnyJg0v52Wn6uXW3lRaXmWPzMbyB0DBTPsOqULxf3DIEyb6AuwsSY1oUrJx2OZrX+itXKNLiHNvLcxaH4mh8oJCOq22o6yy8iny8BeBtrJ8GlEYyFkFKTpc+9bXWSJPX7JFCgT8Nb8q4fnX8vaKVp0hDdrPNL6tMntshoMR5nvXQUoS7Kln802GKJNhL5zUn5p6PihTKpH5DY2RAGXtbf1t+QcuUw2rGMo8jg==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Marek Marczykowski-Górecki <marmarek@xxxxxxxxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 14 Dec 2022 09:34:44 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 14.12.2022 00:03, Demi Marie Obenour wrote:
> This was missed in the initial patchset.
> 
> Signed-off-by: Demi Marie Obenour <demi@xxxxxxxxxxxxxxxxxxxxxx>

I'm sorry, but no: In a v2 submission you should address prior comments.
On v1 I did offer to extend the description while committing, but you
should not take this as an invitation to make the committer again put
more time into getting this into the tree than should actually be needed
(and reviewers to re-figure the unmentioned aspect).

You also will want to get used to adding brief revision log remarks
outside of the commit message area. It would be relevant to know here
there the sole difference from v1 is re-basing.

Jan



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.