[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/platform: Protect XENPF_get_dom0_console if CONFIG_VIDEO not set
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Michal Orzel <michal.orzel@xxxxxxx>
- Date: Wed, 7 Dec 2022 11:38:22 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=suse.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0Tjiam8AlnfbRzfX8LFol6aNNmjXt13tDY9B19T8WZ4=; b=h/X8JoxBe6bXwAtEXa9E1UA2NwzOFeOpTRPeyedeM+xTjro8bmB0TAvrZu75GDu/QCLVBragogWNtVu75DyWaza6wuYJfrB+qQ8jA/5kOmpzQYIhOYX1Bh7pATVyNrvors4FGtBuvJUXYdzSxEBg3hqpehlJWOo9QlmwZzrRD1mMCANQMemsGAJkEFC5lYbMtzcjnoc69V/mO3Y8kf1vYNFhsDHbGZ5Q9fr7bs3c9fhw47SYZ3oNOfpsip30vd5xAKkBnlMTOA1KxVZqqsJ61E4v1sHNeVGUhPsHjqbYxl2eAjiztQrWOR6hCeV4yYMyJOW8zpo/us3xfcdUnDtGgA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NQbKYhTzB/05/ytD3XJ3mXqlHrezbqHnLGAIfa9M0Rw567cU+BPkafPUX6PHhTyrgj9bBQBiHziNsA62rUY+mGe7HlH87hGoNl4LnvBCZ4RPaGoNNgz2JCg+oy6wh9AjNVzbvsZYR/lwEw8N3TLa2JsUc454Bq5f8ZMoa4Ebjs2kkemY6Pg2FR1beD7+s5dqBI69uIBMhtt0Xjyll48mQ8x9uP5bNNpT3Mo8GRDtGnn4l3F3FSObzrKR7ET/MKUZe6mFFZakQBOMlQXQ56LcMlYRLCoeSNWFI9FGsb+8ntAmkmYzGmrcFB0NvVJ6ekd9i1SZsJhPAWrobh6zbKHIug==
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 07 Dec 2022 10:38:41 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Hi Jan,
On 07/12/2022 11:34, Jan Beulich wrote:
>
>
> On 07.12.2022 11:29, Michal Orzel wrote:
>> A build failure [1] is observed if CONFIG_VGA (and thus CONFIG_VIDEO) is
>> not set. This is because XENPF_get_dom0_console cmd of platform hypercall
>> makes a call to fill_console_start_info, which is defined in video/vga.c
>> and built only if CONFIG_VGA is set.
>
> Which means to use ...
>
>> --- a/xen/arch/x86/platform_hypercall.c
>> +++ b/xen/arch/x86/platform_hypercall.c
>> @@ -839,6 +839,7 @@ ret_t do_platform_op(
>> }
>> break;
>>
>> +#ifdef CONFIG_VIDEO
>
> ... CONFIG_VGA here, unless fill_console_start_info() was moved to a file
> that's built dependent upon CONFIG_VIDEO.
The one and only reason of using CONFIG_VIDEO and not CONFIG_VGA is that all the
calls in existing codebase to fill_console_start_info are protected by
CONFIG_VIDEO
and not CONFIG_VGA. That is why I choose to stick to the current behavior.
>
> Jan
~Michal
|
