[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/platform: Protect XENPF_get_dom0_console if CONFIG_VIDEO not set
- To: Michal Orzel <michal.orzel@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 7 Dec 2022 11:34:53 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EViIsttzuBz87+5roiA9RndG9rc2ZEUOwOwQxck2v0s=; b=CE6xyWIxD70YGv6LBSdhSj1zoSt3iC1ctUkfdqNpY4UuSYdJas72OI7OWpjCqlvgwOEt7CHTeKZ0luzqjgO/8dI4U7thHOujzLhaWlIixtG4/xP4uxWjt7HBdHllALzV72S2dZgD53FOXPmhBLddGtS/EDfXP5nU21ecQpnmzn9zaG8mHvIOKy0isBm78xM/0CvB8IeIcM+ZcJ3NCtryJRingLjSC1Z9peyENAG5tkAlRpBovm+Rf+fUNtPukvN0kIPjcMPt1FIeiZDVPzdX9wAuoN6WnWc9jTwlTQYKht8vS9SVXF42uB7LnOwr/TGI7E0Tct6RKrEvbOoyyjbTRg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dTt76jCvPt8/rkOgHytOGdIgp3k4sd16EZDqPxAjS7wVfqxDpF+NWJYwVXgYi0ppJGuWQetfvV90Fbiamcx14GZ8KaeIk3q3TBOObRcP3Vba57WJiVXGKqRYv/3Kf2X5corXeeKQRjZ0mfaA72nyVl6jRBPssb3NVI4JUG1zsmbLt4zMwCeYxnTjW2ANTvRyYULm2GuSVN8+OpUUUU8Xaiky7X8QiQqgoIB7wROJO9Y8L3kYA2hVj23789t7pADUKi1dEAElUyD3BDJ2z+wlPBWsD3MOOC7LqN3JtQVegnfW4S8yVY3DrBwx6gfCBKTzrFHwMdlviSaRg5uqWbHTfA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 07 Dec 2022 10:35:00 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 07.12.2022 11:29, Michal Orzel wrote:
> A build failure [1] is observed if CONFIG_VGA (and thus CONFIG_VIDEO) is
> not set. This is because XENPF_get_dom0_console cmd of platform hypercall
> makes a call to fill_console_start_info, which is defined in video/vga.c
> and built only if CONFIG_VGA is set.
Which means to use ...
> --- a/xen/arch/x86/platform_hypercall.c
> +++ b/xen/arch/x86/platform_hypercall.c
> @@ -839,6 +839,7 @@ ret_t do_platform_op(
> }
> break;
>
> +#ifdef CONFIG_VIDEO
... CONFIG_VGA here, unless fill_console_start_info() was moved to a file
that's built dependent upon CONFIG_VIDEO.
Jan
|
