[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] x86/HVM: drop stale check from hvm_load_cpu_msrs()
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Tue, 6 Dec 2022 14:11:25 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c+m0npt4QPyeDUEqio/9UYts7YZIW4XOwko6on8dO3o=; b=nrEYylHZRTiD4nLmE3AJJVYoAAXp3yTHVa56Njwy0X8EUBr/JuxBCnzJ03lAqQ6XFnf0Wquvd/IlCEjHPbcwP/ILAeyIf1qNJrkkpJ2dsRiuQHnrsfP9l4atzS4uxMZMUFP2hphALuf3cLw2cNuEUxeoyfxT2bVNN2s/MpF6hrpjSArC5Ch9cmqS9uK3ui2PhGufSfcfpZcoUMcuLmhLrFmhVshgAlgL0dawqGcGT7tTr4HYqobmyJsPW87v+aZbn4wJ5hHhi/SmwWpbXo/cMrdjFUAyf98500BH5PUu+5CNxXHvfaUIBT8s1SiEGqLxdxJ2cfbKgFAZP0lZRzxykA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NTYG5Cm91ZvTLvdn82F5BH/1Hm3VoL9iTSrsCJfNXuQgi6mOlUmSQG9KnKuKBAwJHuFEJfzUP53Ho4sUxa0AWPkRUhKJOcA6EfL8S/W4cWMPmcGg4EHhDqQc6hOVrKenTu5x5+LGnCNaLYk2uXEiJEGHF7IK8pbaingCOCsBIGN57e/N/hKFblTuxQQuUl/e5b/bY3rc4i+uTkthK5yR2C64cFYisDMdBlew1/sak9cwW97PQC0CF23OGZKxxUVFgFsiKIhLNz95pwJRnVQ48Rs83nqvffKCQBypc+dsAq7QDEoAOjSI5Tt9ljYD/9efE0036MzWW1XmPRDQDwD48g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>
- Delivery-date: Tue, 06 Dec 2022 14:11:40 +0000
- Ironport-data: A9a23:cRZ6a6siAEh3q6o40Ecp7Ot+LOfnVHRfMUV32f8akzHdYApBsoF/q tZmKW7VM/aOamryfI8gao3i8kIO7JCBx9IxGgpsrH82Qi0a+JbJXdiXEBz9bniYRiHhoOCLz O1FM4Wdc5pkJpP4jk3wWlQ0hSAkjclkfpKlVKiffHg0HVU/IMsYoUoLs/YjhYJ1isSODQqIu Nfjy+XSI1bg0DNvWo4uw/vrRChH4bKj5lv0gnRkPaoR5QWGySFPZH4iDfrZw0XQE9E88tGSH 44v/JnhlkvF8hEkDM+Sk7qTWiXmlZaLYGBiIlIPM0STqkAqSh4ai87XB9JFAatjsB2bnsgZ9 Tl4ncfYpTHFnEH7sL91vxFwS0mSNEDdkVPNCSDXXce7lyUqf5ZwqhnH4Y5f0YAwo45K7W9yG fMwOTIDKQu7gciP0LuLWPRIqskZAtjJFdZK0p1g5Wmx4fcOZ7nmGvyPyfoGmTA6i4ZJAOrUY NcfZXx3dhPcbhZTO1ARTpUjgOOvgXq5eDpdwL6XjfNvvy6Pk0osj/60b4S9lt+iHK25mm6xo G7c8nu/KRYdLNGFkhKO8262h/+JliT+MG4XPO3mpqU20AXKroAVIBNGW3ufvKWBs02/GI5fD U5K+DIripFnoSRHSfG4BXVUukWsvBQRRt5RGO0S8xyWx+zf5APxLngJSHtNZcIrsOcyRCc2z RmZktXxHzttvbaJD3WH+d+8sjeaKSUTa2gYakc5oRAt5tDipMQ/i0zJR9M6Saqt1ISqR3f33 iyAqzU4i/MLl8kX2q6n/FfBxTWxupzOSQ1z7QLSNo640j5EiEeeT9TAwTDmATxode51knHpU KA4pvWj
- Ironport-hdrordr: A9a23:tP1+5qg1lTwVl7hPvN0yBYGM3nBQX/R23DAbv31ZSRFFG/FwyP rCoB1L73XJYWgqM03IwerwQ5VpQRvnhP1ICRF4B8bvYOCUghrTEGgE1/qs/9SAIVyyygc578 tdmsdFebrN5DRB7PoSpTPIa+rIo+P3vpxA592uqUuFJDsCA84P0+46MHfjLqQcfnglOXNNLu v52iMxnUvERZ14VKSGL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftxK/mHwOe1hI+VSoK5bs562 DKnyHw+63m6piAu1/h/l6Wy64TtMrqy9NFCsDJos8JKg/0ggLtSJV9V6aEtDUVpvjqzFoxit HDrzopIsw2wXLMeWOepwfrxmDboXcTwk6n7WXdrWrooMT/Sj5/IdFGn5hlfhzQ7FdllM1g0Y pQtljp9aZ/PFflpmDQ9tLIXxZlmg6funw5i9MeiHRZTM83dKJRl4oC50lYea1wWR4SqbpXVN WGPvusosq+QmnqNkwxeVMfmOBEa05DWStuhHJy4fB9nQImxkyRhHFoufD31k1wiK7VDaM0pN gse54Y6o2nBKUtHN1ALfZETs2tBmPXRxXQdGqUPFT8DakCf2nAspjt/dwOlamXkTMzvekPcb n6ISVlXFQJCgvTINzL2IcO/gHGQW27UziowsZC54Jhsrm5QLbwKyWMRF0njsPl+pwkc4fmcu f2PIgTD+7oLGPoF4oM1wriW4NKIX1bVMEOoN40V1+Hv8qOIIz3se7QdurVOdPWYH0Zc3K6Bm FGUCn4Jc1G4EzuUnjkgALJU3eoYUD79YIYKtmswwHS8vl4CmRhiHlntb3i3LD7FdRriN1HQG JuZLX6j6i8uW66uW7V8mQBAGspMnpo
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHZCXKwXDE1jnevJUKUK9JuHADt765g5lqA
- Thread-topic: [PATCH v2] x86/HVM: drop stale check from hvm_load_cpu_msrs()
On 06/12/2022 13:00, Jan Beulich wrote:
> Up until f61685a66903 ("x86: remove defunct init/load/save_msr()
> hvm_funcs") the check of the _rsvd field served as an error check for
> the earlier hvm_funcs.save_msr() invocation. With that invocation gone
> the check makes no sense anymore: It is effectively dead code due to the
> checking of the field in the earlier loop.
>
> While dropping the conditional also eliminate the "err" local variable
> (using a non-standard name anyway), replaced by suitable new/adjusted
> "return" statements.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
|
