[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 04/21] xen/arm: vIOMMU: add generic vIOMMU framework
- To: Julien Grall <julien@xxxxxxx>
- From: Rahul Singh <Rahul.Singh@xxxxxxx>
- Date: Tue, 6 Dec 2022 09:56:36 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X76SZbhbNN2Lux8ISxBg/1QoARoFPsLobLK9q31qVPQ=; b=EsWIUkEjl/7pfdaYD4/McPFPuPkVrhdDbsKyiKk406dZqNtG0JqqV6e1lyoO+PA7Zuuya6gm0Yq3lTeqtw0/fobqIWMam8UF+ZmqnmtLSpV6V01fvmIvzEmKVqijm3lOAm2ckfVl9uXnx7vk4VeVxjVUskWhESMX/noRjn5JGVv8Hl1P8LLnqXyQTQ26Qy+6lhGOft8WqQq/nAnnCm/1LvVm6zA/fYZX++eDbnREBpNSiJEM+XCWSYW4wYyN+TCOGTMcTe4TUvUC+urJDQ6xAggWFiP9Nd7wR+0ukPl67n0mBy3JN6BkngdsXpFDlz6O++AWC/00sOonVahzlltnLQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lrVCRCT/yhaS6cDnZOyfjOOTQaZ6OMJaBJc6FiUcmYUkuKi38KIi9bq+1/KT3nfrIfG4e9nIEbAxiDuuHyA/zE+lPYt0H5LuF+8ESAIioSV502NePVklbV8MtFP8WMVXeDI8bXel8vY96drwN5QwPiUsl8VSwwkKIlgGXU+fOAXSNx9Bfi0yaUkBBpEBYCxWTSo4LbqI2sB0oERpFbCxj7KBpkok2GFCaz6gEYjziv/l6LMULBEEaJ8TCmwtJFn4+oj217ue31IeV0kOcZk+oX2y1J/WUeLYlkKGFHTGjk+t+i3TANTQEWN9dd9GRlTpMl6V2Yqh2Q36pg+KKf2ssw==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Michal Orzel <michal.orzel@xxxxxxx>, Xen developer discussion <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Tue, 06 Dec 2022 09:56:58 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHZBZ7dBYCbekoSiE+Vqn2CZKLLUK5e+1eAgABbRACAAAkRgIAAD0UAgAE30wA=
- Thread-topic: [RFC PATCH 04/21] xen/arm: vIOMMU: add generic vIOMMU framework
Hi Julien,
> On 5 Dec 2022, at 3:20 pm, Julien Grall <julien@xxxxxxx> wrote:
>
> On 05/12/2022 14:25, Michal Orzel wrote:
>>>>> diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
>>>>> index 1528ced509..33d32835e7 100644
>>>>> --- a/xen/include/public/arch-arm.h
>>>>> +++ b/xen/include/public/arch-arm.h
>>>>> @@ -297,10 +297,14 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_guest_context_t);
>>>>> #define XEN_DOMCTL_CONFIG_TEE_NONE 0
>>>>> #define XEN_DOMCTL_CONFIG_TEE_OPTEE 1
>>>>>
>>>>> +#define XEN_DOMCTL_CONFIG_VIOMMU_NONE 0
>>>>> +
>>>>> struct xen_arch_domainconfig {
>>>>> /* IN/OUT */
>>>>> uint8_t gic_version;
>>>>> /* IN */
>>>>> + uint8_t viommu_type;
>>>> this should be uint16_t and not uint8_t
>>>
>>> I will modify the in viommu_type to uint8_t in
>>> "arch/arm/include/asm/viommu.h" and will
>>> also fix everywhere the viommu_type to uint8_t.
>> Also I think that you need to bump XEN_DOMCTL_INTERFACE_VERSION due to the
>> change
>> in struct xen_arch_domainconfig.
>
> We only need to bump the domctl version once per release. So if this is the
> first modification of domctl.h in 4.18 then yes.
>
> That said, I am not sure whether this is necessary here as you are using a
> padding.
>
> @Rahul, BTW, I think you may need to regenerate the bindings for OCaml and Go.
Ack. I will check this before sending the v2.
Regards,
Rahul
|
