Re: [RFC PATCH 04/21] xen/arm: vIOMMU: add generic vIOMMU framework

[Julien Grall <julien@xxxxxxx>]

On 05/12/2022 14:25, Michal Orzel wrote:
> > > > diff --git a/xen/include/public/arch-arm.h b/xen/include/public/arch-arm.h
> > > > index 1528ced509..33d32835e7 100644
> > > > --- a/xen/include/public/arch-arm.h
> > > > +++ b/xen/include/public/arch-arm.h
> > > > @@ -297,10 +297,14 @@ DEFINE_XEN_GUEST_HANDLE(vcpu_guest_context_t);
> > > > #define XEN_DOMCTL_CONFIG_TEE_NONE      0
> > > > #define XEN_DOMCTL_CONFIG_TEE_OPTEE     1
> > > >
> > > > +#define XEN_DOMCTL_CONFIG_VIOMMU_NONE   0
> > > > +
> > > > struct xen_arch_domainconfig {
> > > >      /* IN/OUT */
> > > >      uint8_t gic_version;
> > > >      /* IN */
> > > > +    uint8_t viommu_type;
> > > this should be uint16_t and not uint8_t
> > I will modify the in viommu_type to uint8_t in "arch/arm/include/asm/viommu.h" 
> > and will
> > also fix  everywhere the viommu_type to uint8_t.
> Also I think that you need to bump XEN_DOMCTL_INTERFACE_VERSION due to the 
> change
> in struct xen_arch_domainconfig.
We only need to bump the domctl version once per release. So if this is 
the first modification of domctl.h in 4.18 then yes.
That said, I am not sure whether this is necessary here as you are using 
a padding.
@Rahul, BTW, I think you may need to regenerate the bindings for OCaml 
and Go.
Cheers,

--
Julien Grall