[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [4.17?] Re: [PATCH] x86/HVM+shim: fix build when !CONFIG_GRANT_TABLE
- To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Thu, 1 Dec 2022 23:31:36 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rnZNryFeysFsqnFksvsUQwhvWeWjJ2FUMVzBH9Ncc6s=; b=OX5S3OhqJYntJQni/XVjfTxjePHPVFwQaEqKv5diQsPwFnVo23uomyoOrUlnwZL7zW9o7GWSEQ0q6f/q/Zdt+4g1i7nfnafMIiJ1wnY9iO24IoVYlO73irULLXuoWzI2tFO9lKJMXIkpy01n1hxxvQaoxa6jKj1VGkLTMR/Buv00L6Lz8rLyoYousfCxrkEni/XCwmboCfV6hxBAmasCprwua9hmSurzbFzSfSfUPzIwQKkWGu+C5svpIOoksQ3IGlGeOx3oiSFi8Ob6nzDZmLeCBC9SabaO8eINAkyXYiqj0n3AmaANTL7sPdv+UPluiY4arZCMqxBsJODxSYwluA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hXH0ihK8JHB1aA2ozCxAxanuaLXC33lFVKVQQW3hy2S2TrpF/sq4QNmfb3rSISokSlMeA5KHtO8u5TiV7Sg8OeiYlcAjUvQsPmV5j8Gubc3Qz6lpFBmX9kHz+M3KtbprvTV6i2xjRxHnlvp7NfProHYVA3qR2h2pO8MQew4LpnvUK6VyN+fnAvYCj5HCExjeemQeLL+3hM92dwu2a/fXLIfkaAUiFErAOXKoSljh0rulGyDcMRElFH6eWwJqOJgGlvyk33OSiCWISionFMY9UdLMNirD4vbEnKtgD/oOwffYEXZyquwPxziHlzXxDUrQxjPTCRguIhH9BZAcZuVAcg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: George Dunlap <George.Dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 01 Dec 2022 23:32:00 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Thread-index: AQHZBZ20FNPkaUdVSkig9Y686gPD965ZMT6AgAAA44CAAAFewIAAMiyAgABItkA=
- Thread-topic: [4.17?] Re: [PATCH] x86/HVM+shim: fix build when !CONFIG_GRANT_TABLE
Hi Andrew,
> -----Original Message-----
> From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
> Subject: Re: [4.17?] Re: [PATCH] x86/HVM+shim: fix build
> when !CONFIG_GRANT_TABLE
>
> On 01/12/2022 16:14, Henry Wang wrote:
> >>> Thanks for investigating.
> >>>
> >>> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> >> Thanks.
> >>
> >>> Thoughts about inclusion into 4.17? This is a build time regression vs
> >>> 4.16.
> >> I thought this was odd enough a configuration, but since you ask, let me
> >> forward the question to Henry.
> > I think a build time regression should be fixed. We cannot assume users
> > will not use this configuration (as Jan pointed out in IRC). So for 4.17:
> >
> > Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
> >
> > But if OSSTest is exploded after merging this patch, I would like to request
> > a revert since we don't have too much time left for the due date. Hopefully
> > everyone is fine with that.
>
> It is very unlikely that people are going have a configuration like this
> in production.
>
> But, the 4.17 branch does have Gitlab CI running on it, including
> randconf tests, which provably do spot the error occasionally.
>
> The (IMO better) justification to take it into 4.17 at this point is to
> fix a CI failure.
Good point, my release ack is still valid :)
Kind regards,
Henry
>
> ~Andrew
|
