[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [4.17?] Re: [PATCH] x86/HVM+shim: fix build when !CONFIG_GRANT_TABLE
- To: Henry Wang <Henry.Wang@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Thu, 1 Dec 2022 19:09:35 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2t7Tbv6gOm9w6RFfcZbwNS0f8dyl8+pBVgGCgYlMgKM=; b=B1Cqq4SHW8dgphdvIeqwqu9DZ73Q3MiY6QvSM//3bZyTl0IhSNrGcgMwRwUwpuwNyn+KZoqrIVdFzHEPFoS8eTdYmRuhkhn+h2xf/wJKNwOPoiZk560YlS+Oz/oDnkc5xurZwkk/JNvcL39e7DDXxwU77+EwxQOn9dKW0bGyfCmatXiasbJaejUTGLvqdsdpMnu4r1kfofb69OBM0GlehAzoRspFt3T49EeTHYeI80eE04r3Y2FlZFdFUDkXrLPj+F41p2UwEJa8omAL2u4uFRJIko7mHi2xLRxUVm1YoCUIE4FWY5LIXlKMbob8RsEJKQUXG51nqj6Nl/+NbW58aw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dHK5bDaQOGEdS3nadntIvTkJBnuSw3DZFUkxZZRooD7qxDDshFRcW0/KYGFacLppYAtLgx3OiP7t5Iw34J2LRpE83Ppyuej0Op+0Dh5/BDVWuKxeW1l4OB8e9eTbweesH+hpPrt8yxsWSB6q4BGEo3drYB/RAVTzEbVxsbuxJOrzy4MLeG/FVVYaREqZXBa0mBuFJqR2GRYRRE4xab4BQmJnbhliuO8eFmM64lL8xS7j1cOwUitaBA0vtsfQFMcswGE4lojHM3Xd6SwzFtvqI1zikKL7vtZgX48qK/QmePaLwQ/DC/hyNy+2kc7yMI6IdLcBTFsfibBEQ/vNsC1oJw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: George Dunlap <George.Dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 01 Dec 2022 19:09:52 +0000
- Ironport-data: A9a23:8Urb16A9iykSNhVW/87iw5YqxClBgxIJ4kV8jS/XYbTApGkqhTIEz WQcWT+FP/jeYWqmKNAgbYy/8EoAu57WnIVnQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtcpvlDs15K6o4WlA5wRlDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIwwukoOCJA1 uwkLhcRViCqq++7w4yVRbw57igjBJGD0II3nFhFlGucKMl8BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTL++xrsgA/zyQouFTpGPPTdsaHWoN+mUGAq 3id12/4HgsbJJqUzj/tHneE1rGWxHKkAtt6+LuQ2sU6uBqt5kgqAhw4SXqbv9yVukWhcocKQ 6AT0m90xUQoz2SLQ9/nTluHqXiLlhcGXpxbFOhSwAOHx7fQ4g2ZLnMZVTMHY9sj3Oc0WDgr2 1mhj97vQzt1v9W9UmmB/72ZqTezPyk9LmIYYyIACwwf7LHLv4Ubnh/JCNF5H8adntDzXD393 T2OhCw/nKkIy94G0b2h+lLKiC7qoYLGJjPZ/S3SV2OhqwZmPoisYtXy7UCBtaoRaoGEUlOGo X4I3dCE6/wDBo2MkyrLR/gRGLau5LCONzi0bUNTIqTNPg+FoxaLFb28KhknTKu1Gq7ooQPUX XI=
- Ironport-hdrordr: A9a23:iG31s6+n4Ehg7n8H7thuk+H6dr1zdoMgy1knxilNoENuA6mlfp GV7ZYmPEHP+VUssSkb6KC90KnpewKlyXcH2/hjAV7CZnikhILMFupfBOTZskHd8kHFh4hgPO JbAtlD4b7LfBpHZKTBkXaF+r8bqbHmgcTY4ts2jU0dMz2CAJsQlDuRfzzrb3GeMzM2f6bReq Dsn/avWQDORZ3tVKmG74U+PtQrXeegqHsYW3I77uMchjWmvHeN0vrXAhKY1hARX3dmxqojy3 HMl0jU97iuqPayzz7bziv2445NkNXs59NfDIjU4/JlbgnEu0KNXsBMSreCtDc6rKWG70srqs DFp1MNLtl+8HTYe0CyuF/I1xP72Dgjxnf+wRuzgGflo+b+WDUmYvAxwL5xQ1/80Q4Nrdt82K VE0yayrJxMFy7Nmyz7+pzhSwxqvlDcmwtlrccjy1hkFacOYr5YqoISuGlPFo0bIS784Ic7VM FzEcDn4upMe1/yVQGBgoAv+q31Yp0AJGbdfqEwgL3J79GQpgEk86Is/r1Fop7HzuNjd3AL3Z WbDk0irsA9ciZfV9MJOA5Ge7rxNoWFe2O5DEuCZVvgD60JIHTLttr+56g0/vijfNgSwII1g4 mpaiIXiYecQTOkNSSi5uwGzvn2ehTzYR39jsVFo5RpsLz1Q7TmdSWFVVA1isOl5/ESGNfSVf q/MI9fR6aLFxqvJa9ZmwnlH5VCI3gXV8MY/t49RlKVu8rObonnrPbSfvrfLKfkVTwkRmT8CH 0eWyWbHrQA0mm7HnvjxBTBUXLkfULyuZp2DajB5uAWjJMAM4Vd2zJlxGhQzamwWEp/W2wNDQ FDyZ/c4+uGTDONjBD1Bk1SS1NgMno=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHZBZ2nWTAZIWB6y0GC+MRiLhYZVK5ZMT6AgAAA44CAAAKIgIAAMQEA
- Thread-topic: [4.17?] Re: [PATCH] x86/HVM+shim: fix build when !CONFIG_GRANT_TABLE
On 01/12/2022 16:14, Henry Wang wrote:
>>> Thanks for investigating.
>>>
>>> Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> Thanks.
>>
>>> Thoughts about inclusion into 4.17? This is a build time regression vs
>>> 4.16.
>> I thought this was odd enough a configuration, but since you ask, let me
>> forward the question to Henry.
> I think a build time regression should be fixed. We cannot assume users
> will not use this configuration (as Jan pointed out in IRC). So for 4.17:
>
> Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
>
> But if OSSTest is exploded after merging this patch, I would like to request
> a revert since we don't have too much time left for the due date. Hopefully
> everyone is fine with that.
It is very unlikely that people are going have a configuration like this
in production.
But, the 4.17 branch does have Gitlab CI running on it, including
randconf tests, which provably do spot the error occasionally.
The (IMO better) justification to take it into 4.17 at this point is to
fix a CI failure.
~Andrew
|
