RE: [PATCH v3 1/3] CHANGELOG: Add missing entries for work during the 4.17 release

[Henry Wang <Henry.Wang@xxxxxxx>]

Hi Julien,

Thanks for your review as always!

> -----Original Message-----
> From: Julien Grall <julien@xxxxxxx>
> Subject: Re: [PATCH v3 1/3] CHANGELOG: Add missing entries for work during
> the 4.17 release
> 
> (Reducing the CC-list)

Thanks, I will use this CC-list in v4.

> 
> Hi,
> 
> On 22/11/2022 11:26, Henry Wang wrote:
> > Signed-off-by: Henry Wang <Henry.Wang@xxxxxxx>
> > - - Support VIRT_SSBD feature for HVM guests on AMD.
> > + - Support VIRT_SSBD feature for HVM guests on AMD and
> MSR_SPEC_CTRL feature for
> > +   SVM guests.
> 
> Did you really intend to write "SVM" rather than HVM? If yes, then to me
> "HVM guests on AMD" means the same as "SVM guests".

I am sorry about the confusion. I think the latter part of this sentence is
just a direct copy of title in [1]. But by reading the content of that
cover letter I think...

> 
> So I would suggest the following wording:
> 
> Support for VIRT_SSBD and MSR_SPEC_CTRL for HVM guests on AMD.

...this is correct. So I will use your suggested sentence in v4. Thanks.

> 
> > + - Support VirtIO-MMIO devices in toolstack on Arm.
> 
> I would clarify that this is *only* creating the device-tree binding.
> IOW, there are no support for ACPI nor device-emulator (still in
> progress from Xen Project PoV).

You are correct. I will change to:
"Support VirtIO-MMIO devices device-tree binding creation in toolstack
on Arm"

> 
> > + - Allow setting the number of CPUs to activate at runtime from command
> line
> > +   option on Arm.
> > + - Grant-table support on Arm was improved and hardened by
> implementing
> > +   "simplified M2P-like approach for the xenheap pages"
> > + - Add Renesas R-Car Gen4 IPMMU-VMSA support on Arm.
> > + - Add i.MX lpuart and i.MX8QM initial support on Arm.
> 
> I was under the impression that the code that was merged is enough to
> support the platform. Do you have any pointer where it says it is not
> sufficient?

Ah this is also directly from the title of [2], where it is only a
"xen/arm: add i.MX lpuart and i.MX8QM initial support"

I would be more than happy to remove the "initial" if you think it is
appropriate.

> 
> > + - Improved toolstack build system.
> > + - Add Xue - console over USB 3 Debug Capability.
> >
> >   ### Removed / support downgraded
> >    - dropped support for the (x86-only) "vesa-mtrr" and "vesa-remap"
> command line options

[1] 
https://lore.kernel.org/xen-devel/20220128132927.14997-1-andrew.cooper3@xxxxxxxxxx/
[2] 
https://lore.kernel.org/xen-devel/20220419043927.23542-1-peng.fan@xxxxxxxxxxx/

Kind regards,
Henry

> 
> Cheers,
> 
> --
> Julien Grall