[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/Viridian: don't mark IRQ vectors as pending when vLAPIC is disabled
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Mon, 21 Nov 2022 14:47:13 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yXx8/D21ie/hTcCChUKVy4Q00hWiNLKaJ6gn9AWZOEA=; b=aBYKa2+t5+/w8nA2KdvdTIYXAx2vrq2S3oGlenp3uLFFvjxBeAqwyP/HNfY6ve2Z08VqAqjy9AZrCAo3gag1QupHDHCFdxGHMumBmShbnKD5K14iIHZnbO88ylxHDQs+YmSpqZuVgA1kaRKK+h136FlIWbeQ+w0F7y1DgsNJ5B80OXJOFGDRhY385AErwRiP1kA2QMKFztyLkwfJHG8VcXHCXAWbmvFG71nRXL/6IuX9gOeffGiXCmUydRf0k+BerQlKUooxHw58iYSAITTY1OGE/a0Z8MRfVyVcTh2vpugQPOY8lUir4uNlWjfnP5lbXPqftcGsOIk3jOF1O5xwvw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=niw8r5LMfZhTidkGRY5v9nDilQl5qXbMmMssmi4DHVHqk3mEDsm3NiRKHYAzxZ/iVGlymiMNIuooAVQtw6w+HG6xUBePi+VFG0zhcyl/dX3IC/cPP0LFQR0cyZ1nBbU0eE9aXz1Z1cxrQ8/FBk5yR59lJ00H2+ZW1nVFnshKqnS+GTsmPO/HvQBrjxBl3uIApyd7HWqRmpCYgPDub8+g3xJyMCWcWPBsnxJwTXWfGZJ9qiXrXr4LHMv/MFhTbc656k9ajMN66jyCR++grJ1BQx+HAiFjuUqjafU0WHFhF1cHcYAJkhz5BBwZq6/2wCk73HGtVc+YhTlToLF05s8wxg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Paul Durrant <paul@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>
- Delivery-date: Mon, 21 Nov 2022 14:47:27 +0000
- Ironport-data: A9a23:zeqvFa7mVOHEB5hm5v5T/gxRtAjGchMFZxGqfqrLsTDasY5as4F+v jYXWG7XOv2MZzDyL9wlOYzgoR4Fv57RxtZkTVM9qi9hHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4pwehBtC5gZkPKkR5QeH/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m5 PhHcg4VUxu5qvux4riFFNN+ict6M5y+VG8fkikIITDxK98DGMqGb4CUoNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6OnUooj+eF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNJOROblr6Iz6LGV7jQJOAI4WByBmuOwlmPgd/tOA EI69SV7+MDe82TuFLERRSaQonSJoxodUNp4CPAh5UeGza+8yxaUAC0IQyBMbPQitdQqXno62 1mRhdTrCDdz9rqPRhq17r6JqRuiNC5TKnUNDQcbSSMV7t+lp5s85i8jVf5mGa+xy9HwRzf5x mnQqDBk3upMy8kWy6+84FbLxSq2oYTERRI04QORWX+56gR+Z8iuYInABUXn0Mus5b2xFjGp1 EXoUeDHhAzSJflhTBCwfdg=
- Ironport-hdrordr: A9a23:cRIY2KotBsdqLP65isxa5MIaV5sDLNV00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssSkb6Ku90KnpewK+yXbsibNhcItKLzOWwldAS7sSobcKogeQUREWk9Qw6U 4OSdkYNDSdNzlHZIPBkXGF+rUbsZa6GcKT9IHjJh5WJGkEBZ2IrT0JczpzeXcGJjWucKBJcK Z0kfA3wgZIF052Uu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyR+49bLgFBCc/xEGFxdC260r/2 TpmxHwovzLiYD79jbsk0voq7hGktrozdVOQOSKl8guMz3pziq4eYh7XLWGnTYt5MWi8kwjnt Xgqwope+5z93TSVGeopgaF4Xiv7B8er1vZjXOIi3rqpsL0ABggDdBauI5fehzFr2I9odBVys twriGknqsSKSmFsDX25tDOWR0vvFGzu2AenekaiGEaeZcCaYVWsZcU8CpuYdU99WPBmcUa+d tVfYbhDcVtABWnhrfizzBSKemXLzAO99G9MxA/U4KuomNrdTtCvjYlLYQk7ws9HdQGOtl5Dq 3/Q9pVfPsldL5oUYttQOgGWse5EWrLXFbFN3+TO03uEOUdN2vKsIOf2sR92AiGQu1+8HIJou W2bHpI8WopP07+A8yH25NGthjLXWWmRDzojsVT/YJwtLHwTKfidXTrciFkr+Kw5/EERsHLUf e6P5xbR/flMGv1AI5MmwnzQYNbJ3USWNAc/tw7R1WNqMTWLZCCjJ2STN/DYL72VTo0UGL2BX UOGDD1OcVb90iuHmT1hRDAMkmdDnAXPagAZZQy09Jju7TlbLc8wzT9oW7Jlv2jOHlFrrE8el d4Lffujr67zFPGj1r10w==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHY/aLC8acXtzuGekaGc6l+6XhP265JdQKA
- Thread-topic: [PATCH] x86/Viridian: don't mark IRQ vectors as pending when vLAPIC is disabled
On 21/11/2022 12:13, Jan Beulich wrote:
> In software-disabled state an LAPIC does not accept any interrupt
> requests and hence no IRR bit would newly become set while in this
> state. As a result it is also wrong for us to mark Viridian IPI or timer
> vectors as having a pending request when the vLAPIC is in this state.
> Such interrupts are simply lost.
>
> Introduce a local variable in send_ipi() to help readability.
>
> Fixes: fda96b7382ea ("viridian: add implementation of the
> HvSendSyntheticClusterIpi hypercall")
> Fixes: 26fba3c85571 ("viridian: add implementation of synthetic timers")
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
|
