[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/HVM: don't mark external IRQs as pending when vLAPIC is disabled
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Mon, 21 Nov 2022 14:45:52 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hp9P61fgn1RuHvIj1Cz0V1fKbLBHYOGLcBRppAK30rY=; b=YlEmUNWgCGoj2jm8GNKmbbvOmewwPL/d+IXpnbepsTETRga7W7S7tNDRgBH7UHVwD5F0cYGU9HjfJYDkuuA+nhbjgzfOxDxg95vyTQHoQwBWDBH7u7+XIPG3xwhaFuwSbx1zWbVYb2CcLoZZCDzqer8ocV8UwLUcMz3Cif1eekk2xxhLSTip5jxEw2d1fev4RPd+Z7yY0l2iDSfdGNDtqV3ubQXGF/25dSu3dHok3dCobUT7JhSXueJLD0gqmwgAAB43fq/SY0bz9FYtrDKGjSVGhWCKXlmYaiB3HBWBEpGtmjyFJVDo2hnXwmKYiig1dqMeIVWJptDFvz1hcv7r5w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YUcspBl0LERqARwtM4FvS2vOaV5HjBCVBkcDXR0J9Yc8u0memeR8YJzqIB3bgpaNWDyLr7b9ewwZyBtAinXR/z0PS4SgBTLI8gil4LSu6zpTtN04Zgq5VpAcFgVbPWnkDv39fIeGzj88lFTx7AIghTso0kDMY5Y4V4nlkEd+1Gyfi/hAXe/zf3MDFSkanVqATnMXsTx1tC0WGO5ChmBcTI3ebnq/zHyyoZcVFz9j8qh5WaHMNEuhmgqlJ71TfjBk0ROGftOLjLPXdj3uq9mBALYhM3i5ha3klsXXDeM6Gf3o7NQxB9SFClubAnBTmI+zxUXi3JmDmjtilkhOqqbjAg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>
- Delivery-date: Mon, 21 Nov 2022 14:46:00 +0000
- Ironport-data: A9a23:vzXvw65rhkHQq4GHP5x1zAxRtBrGchMFZxGqfqrLsTDasY5as4F+v mRLXD3VMqvZZWb1Lo91YYrjp0oC65CDm9dmTQA/rCEzHi5G8cbLO4+Ufxz6V8+wwm8vb2o8t plDNYOQRCwQZiWBzvt4GuG59RGQ7YnRGvynTraBYnoqLeNdYH9JoQp5nOIkiZJfj9G8Agec0 fv/uMSaM1K+s9JOGjt8B5mr9VU+4pwehBtC5gZkPKkR5QeH/5UoJMl3yZ+ZfiOQrrZ8RoZWd 86bpJml82XQ+QsaC9/Nut4XpWVTH9Y+lSDX4pZnc/DKbipq/0Te4Y5iXBYoUm9Fii3hojxE4 I4lWapc6+seFvakdOw1C3G0GszlVEFM0OevzXOX6aR/w6BaGpdFLjoH4EweZOUlFuhL7W5m2 /BBExInTCG6vt2Z0JKrWLRP28URFZy+VG8fkikIITDxK98DGMmGaIKToNhS0XE3m9xEGuvYa 4wBcz1zYR/cYhpJfFAKFJY5m+TujX76G9FagAvN+exrvC6Okkooj+WF3Nn9I7RmQe18mEqCq 32A1GP+GhwAb/SUyCaf82LqjejK9c/+cNJPTuDjp6cw6LGV7jE9DDswRVSrnd6e1X75C5VAD 2sp5RN7+MDe82TuFLERRSaQonSJoxodUNp4CPAh5UeGza+8yxaUAC0IQyBMbPQitdQqXno62 1mRhdTrCDdz9rqPRhq16bO8vT60fy8PIgc/iTQsSAIE55zop9g1hxeWF9J7Svfq05vyBC36x C2MoG4mnbIPgMUX1qK9u1fanzaroZuPRQkwjunKYl+YAspCTNbNT+SVBZLzsZ6s8K7xooG9g UU5
- Ironport-hdrordr: A9a23:QgsC06rAd5BM3/Rkkw9yblgaV5sDLNV00zEX/kB9WHVpm5Oj+v xGzc5w6farsl0ssSkb6Ku90KnpewK+yXbsibNhcItKLzOWwldAS7sSobcKogeQUREWk9Qw6U 4OSdkYNDSdNzlHZIPBkXGF+rUbsZa6GcKT9IHjJh5WJGkEBZ2IrT0JczpzeXcGJjWucKBJcK Z0kfA3wgZIF052Uu2LQl0+G8TTrdzCk5zrJTYAGh4c8QGLyR+49bLgFBCc/xEGFxdC260r/2 TpmxHwovzLiYD79jbsk0voq7hGktrozdVOQOSKl8guMz3pziq4eYh7XLWGnTYt5MWi8kwjnt Xgqwope+5z93TSVGeopgaF4Xiv7B8er1vZjXOIi3rqpsL0ABggDdBauI5fehzFr2I9odBVys twriGknqsSKSmFsDX25tDOWR0vvFGzu2AenekaiGEaeZcCaYVWsZcU8CpuYdU99WPBmcUa+d tVfYbhDcVtABWnhrfizzBSKemXLzAO99G9MxA/U4KuomNrdTtCvjYlLYQk7ws9HdQGOtl5Dq 3/Q9pVfPsldL5oUYttQOgGWse5EWrLXFbFN3+TO03uEOUdN2vKsIOf2sR92AiGQu1+8HIJou W2bHpI8WopP07+A8yH25NGthjLXWWmRDzojsVT/YJwtLHwTKfidXTrciFkr+Kw5/EERsHLUf e6P5xbR/flMGv1AI5MmwnzQYNbJ3USWNAc/tw7R1WNqMTWLZCCjJ2STN/DYL72VTo0UGL2BX UOGDD1OcVb90iuHmT1hRDAMkmdDnAXPagAZZQy09Jju7TlbLc8wzT9oW7Jlv2jOHlFrrE8el d4Lffujr67zFPGj1r10w==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHY/aKo13OJiWHN50yw2/gbAohrPK5JdKIA
- Thread-topic: [PATCH] x86/HVM: don't mark external IRQs as pending when vLAPIC is disabled
On 21/11/2022 12:13, Jan Beulich wrote:
> In software-disabled state an LAPIC does not accept any interrupt
> requests and hence no IRR bit would newly become set while in this
> state. As a result it is also wrong for us to mark IO-APIC or MSI
> originating vectors as having a pending request when the vLAPIC is in
> this state. Such interrupts are simply lost.
>
> Introduce (IO-APIC) or re-use (MSI) a local variable to help
> readability.
>
> Fixes: 4fe21ad3712e ("This patch add virtual IOAPIC support for VMX guest")
> Fixes: 85715f4bc7c9 ("MSI 5/6: add MSI support to passthrough HVM domain")
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
|
