[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/pvh: do not forward MADT Local APIC NMI structures to dom0
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 17 Nov 2022 12:05:36 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZOPem5wlv44zkGOeFPMl74oN24xthUeEZJcqZUxn0jY=; b=LCRZ62GkrIdOnS0iBsNO3juu0wedKpjGNIyhLrWoSl0iIcrOvsCtUGnLtQA8Dm0rOwU3kblPbKvY2++Brk3eh/MfGajFl9E8WI+qd8gnW9Prymi2zJDVsetimmyCRRr6bArFZkWC4QtapYOdYYLe+s7PivoziHqdiEHBcyZPYFp9uysatbLtCO3t5OUnrgVeKDpJoeo2pX4epy9c756m9jlVKoJfsieer8aVdJGj/9mPKtt1FO0UkHk5pmTkv6aIxhJOTBh7mqZLOCDt1D2wzFuutpQzFR5bKXODKduCa7J55QXoTLJ4TLjg7Obnlvy8o1yA90kO7u2YCHO0f4Xpxw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bqseZaqo3AWopjD7rTyhHm8S60fhlx78pXk/DFuZ9WSoB7oodZPjPoTL+TSWCwK/CdQp4QzKJK/H0T8dmnVtecNKkgtHUI1jTEfqcUrSAJu1ySdFczbamsPALoT8QdfiqxIgTXeqW7jI3wXoJWAPeozX8fUCy6rBBGGm5fMvdbfw7d9RsaauP+1/0NO1zjyb/n0+dmNOa1Ymg8FtXmWN412Xqkb7d+7ErIQMlg2BLTA/i/4BLVwQY31E7UAhyq4vS7FjzKxbhR0LG8MbE1TnimIgYOZbefp9/4puGCXzbnfwYInjA2fzEj51cRmPZVfLsNXnK6bFdKXOk9de/sCa1g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 17 Nov 2022 11:05:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 17.11.2022 11:23, Roger Pau Monné wrote:
> On Thu, Nov 17, 2022 at 10:27:41AM +0100, Jan Beulich wrote:
>> On 16.11.2022 17:42, Roger Pau Monne wrote:
>>> Currently Xen will passthrough any Local APIC NMI Structure found in
>>> the native ACPI MADT table to a PVH dom0. This is wrong because PVH
>>> doesn't have access to the physical local APIC, and instead gets an
>>> emulated local APIC by Xen, that doesn't have the LINT0 or LINT1
>>> pins wired to anything. Furthermore the ACPI Processor UIDs used in
>>> the APIC NMI Structures are likely to not match the ones generated by
>>> Xen for the Local x2APIC Structures, creating confusion to dom0.
>>
>> Plus we should have passed through Local x2APIC NMI Structures then as
>> well.
>
> Sadly this is not possible for PVH dom0, Linux will use the ACPI
> Processor UID as vCPU ID in hypercalls, so if the UIDs don't start at
> 0 and are sequential Linux will panic during boot because vCPU
> operations will fail.
Sure - I was merely hinting at the original attempt having been incomplete
(besides being flawed as per the description here).
Jan
|
