[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/pvh: do not forward MADT Local APIC NMI structures to dom0
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Thu, 17 Nov 2022 11:23:32 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1+CUtBcibqspFiL78oEpMfHbMCUtnnB6OiY+vXqjO74=; b=mxDkyorFUT5ZNdYZulugGgKrEJMs0JOevLgGL2eL0IZYJNd++PTbt8+E/zm6OjGlX09SQgvHJvx+6liVhlswSBIzPpT5HMHc6+eRq6OzXbHot+1A2z7/yWw4FzpHcHDVPZKPLcZDjZmmTm98MKZLCPKeGU0Z2rf6yPS05yI6kruEOuHo8QREZWiD0byMGBPVLeqh5vF6d1ilkmbANwzFB5x7ClWyP6zxi4UvsOJqNw+85/wViPoxNXuirauyPpnbLZiht/8gsYpVzyfMBVdZnh6BXSS/q4O2pXtQMnri4nRASjtiJOcwOE57iifVn34u9D57Qi1R5s+7Q9x5/CvDgQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IgQsa86kYP4+MldEeS5qwXpnX9xp9SqsRJNh2WZvNDM+X8iyBrMsz31z6F+qvw0XkI7eYAEF9Lsbx+H8apJ36T5OHtl/JPci5hBkPkgT11YUJCURBYBsu5PCVK511LlLdermnfne0sERHPgNfXprsI3DB1XtjXyx5kwUbOzM8H6tQIn2XZxmx5UfzVpf2mxnD6Vq75JoV51riW2lnwlNXRUA2WN2m7KQJrZYxjwa1zgPHFdX7VQOQPVM4dZ5lYcmLKXXgQ0DkJKytferQs15/en43kCTXihEYwN2j4hsFuGuSTxyUSlA89+0/Me+8Alg/rxQS+7teraI4edsJuHmUw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 17 Nov 2022 10:23:53 +0000
- Ironport-data: A9a23:vDhWJqBUAFE5kRVW/w7iw5YqxClBgxIJ4kV8jS/XYbTApGhwgTYAn 2JMD2GFbvyCYGvzL9l1Oovi8E4Dv8DdydBmQQY4rX1jcSlH+JHPbTi7wuUcHAvJd5GeExg3h yk6QoOdRCzhZiaE/n9BCpC48T8nk/nNHuCnYAL9EngZbRd+Tys8gg5Ulec8g4p56fC0GArIs t7pyyHlEAbNNwVcbyRFtcpvlDs15K6o4WpB4QRkDRx2lAS2e0c9Xcp3yZ6ZdxMUcqEMdsamS uDKyq2O/2+x13/B3fv8z94X2mVTKlLjFVDmZkh+AsBOsTAbzsAG6Y4pNeJ0VKtio27hc+ada jl6ncfYpQ8BZsUgkQmGOvVSO3kW0aZuoNcrLZUj2CA6IoKvn3bEmp1T4E8K0YIw/O8wAzxB+ NwjLg8hRUmkpb2s2ZS4Vbw57igjBJGD0II3nFhFlGmcKMl8BJfJTuPN+MNS2yo2ioZWB/HCa sEFaD1pKhPdfxlIPVRRA5U79AuqriCnL3sE9xTI+OxuuzS7IA9ZidABNPLPfdOHX4NNl1uwr WPa5WXpRBodMbRzzBLVrS/x27eSw0sXXqotT4OG09RSg2fO11VUBDpRXAaAjuuQ3xvWt9V3b hZ8FjAVhao4+VGvT9L9dwalu3PCtRkZM/JPF8Uq5QfLzbDbiy6JC25BQjNfZdgOsM4tWSdsx lKPh8nuBzFkrPuSU331y1uPhTa7OCxQKHBYYyYBFFMB+4O6+N11iQ/TRNF+FqLzlsfyBTz73 zGNqm45mqkXiskIka68+Dgrng6Rm3QAdSZtji2/Y45vxloRiFKND2Bw1WXm0A==
- Ironport-hdrordr: A9a23:O2qQnam3Ia/S2j+MrFLyr2in10jpDfNMiWdD5ihNYBxZY6Wkfp +V8cjzhCWftN9OYhodcLC7V5Voj0mskKKdxbNhRYtKOzOWw1dATbsSlLcKpgeNJ8SQzI5gPM tbAstD4ZjLfCJHZKXBkXaF+rQbsb66GcmT7I+xrkuFDzsaDZ2Ihz0JdjpzeXcGIDWua6BJdq Z1saF81kedkDksH7KGL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftxK/mHwOe1hI+VSoK5bs562 DKnyHw+63m6piAu1Xh/l6Wy64TtMrqy9NFCsDJos8JKg/0ggLtSJV9V6aEtDUVpvjqzFoxit HDrzopIsw2wXLMeWOepwfrxmDboX0Twk6n7WXdrWrooMT/Sj5/I81dhbhBeh+cz0Y7ptlz3I 9Cwmrc7vNsfFv9tRW4w+KNewBhl0Kyr3ZnuekPj0ZHWY9bTLNKt4QQ8G5cDZ9FNiPn74IMFv VoEajnlb9rWGLfS0qcknhkwdSqUHh2NhCaQnIassjQ6DRSlGAR9Tps+OUv2lM7sL4tQZhN4O rJdo5ykqtVc8MQZaVhQM8cXMqeEAX2MFzxGVPXBW6iOLAMOnrLpZKyyq4y/vuWdJsBy4Z3sI jdUWlfqXU5dyvVeIKzNaVwg1DwqViGLHfQIpk03ek6hlS8fsumDcS7ciFuryP6yM9vR/EyWJ 6ISeBr6rHYXC/T8L1yrn3DsqlpWAcjufIuy6cGsnK107b2w97Rx5vmWceWAobROhAZfU66Kk c/fVHIVbZ9BwaQKzLFvCQ=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Nov 17, 2022 at 10:27:41AM +0100, Jan Beulich wrote:
> On 16.11.2022 17:42, Roger Pau Monne wrote:
> > Currently Xen will passthrough any Local APIC NMI Structure found in
> > the native ACPI MADT table to a PVH dom0. This is wrong because PVH
> > doesn't have access to the physical local APIC, and instead gets an
> > emulated local APIC by Xen, that doesn't have the LINT0 or LINT1
> > pins wired to anything. Furthermore the ACPI Processor UIDs used in
> > the APIC NMI Structures are likely to not match the ones generated by
> > Xen for the Local x2APIC Structures, creating confusion to dom0.
>
> Plus we should have passed through Local x2APIC NMI Structures then as
> well.
Sadly this is not possible for PVH dom0, Linux will use the ACPI
Processor UID as vCPU ID in hypercalls, so if the UIDs don't start at
0 and are sequential Linux will panic during boot because vCPU
operations will fail.
> > Fix this by removing the logic to passthrough the Local APIC NMI
> > Structure for PVH dom0.
> >
> > Fixes: 1d74282c45 ('x86: setup PVHv2 Dom0 ACPI tables')
> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> albeit with the implied ack in there provisional upon Andrew accepting
> your response to his reply.
Thanks, Roger.
|
