[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.17?] x86/paging: return -EINVAL for paging domctls for dying domains
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 10 Nov 2022 10:03:57 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pft+1Z+vRWwJOdgy/8sxq8vUhX/cZ7q9kPsXa+supH8=; b=lAJc/9xbw/QIWakVL4b+JOHinxzenuQ3jA3pglgOpx2/G7qrp0pan6dG9OALQ5q7ecZ9mobfDEr4OuR4CbLC9n/UKwzdbeCHhHdUwziX5wnq+1BsbaaZB/TBt8zk2IvDysH5hET/BTe0xgcU6SGkUz44qGVmoUTOgi6aemnSRXUCpHhYPcQOfE1jif5JDX7FTAy4NaOP5jubMfRsUxsAhbF44BXwLqpMMfjw3tgTtHAtP1Ffp1Yur/SHrXWnl49Oz3bN4+EJpP9fVowVn+YHHCk0E3syCc7R+NRsEnZl77HcqNvNAPRyl90KRpvI9qIxb2K5lCD0TYshNlRsXm+Rrw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DXZt3f4z2BoV9yK3RvnI/laJG/lRn9fNAxPS9jC1KYign/kycPizKuseT/ByX3dHLZw5SX6slasMwpMvu9VG36YW4cX6Dzt1NGA8S9eAfYdUmAsK7lgqEnP6IEleCVdK2/h8Yv9ZVyqp3m45FiD2jUOkusP3Vp/xY8toyt2RcybXG5QlcA0CUBkEXiwrmEIAMjFd7WJp4C1G2Ts40uNTrZQuWgmPr2mEndeCmGnI2AtUp6hSpGYo6zFl0CG98VR6ZIjYaaXnXXAWV96ueGQc0qJsfT+p8GNyNXbhVDtPrb3VbtpbTrt/qQfQvT5p6r3o2W8u42m7qVnO+Kf1cgF1qw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Henry.Wang@xxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Edwin Török <edvin.torok@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 10 Nov 2022 09:04:04 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 09.11.2022 14:22, Roger Pau Monné wrote:
> On Wed, Nov 09, 2022 at 01:02:28PM +0100, Jan Beulich wrote:
>> On 09.11.2022 12:36, Roger Pau Monné wrote:
>>> Since I don't see replies to my other comments, do you agree on
>>> returning an error then?
>>
>> No, my view there hasn't changed. I wouldn't block a change to go in
>> early for 4.18, but I also wouldn't ack such.
>>
>> Perhaps just one remark on your other earlier comments: While you're
>> right about XEN_DOMCTL_SHADOW_OP_{CLEAN,PEEK}, (effectively) random
>> data in the bitmap may cause a caller to do extra work, but wouldn't
>> look to be otherwise harmful: Considering pages dirty which aren't
>> is never a functional problem, while considering pages clean which
>> aren't is (imo) not a problem for a dying domain.
>
> Can't that lead to failures elsewhere when attempts to fetch those
> pages find they might have been removed from the p2m?
Quite possible, yes.
Jan
|
