[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.17?] x86/paging: return -EINVAL for paging domctls for dying domains
- To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 10 Nov 2022 10:02:21 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pGEUzAM/tBuNXyuGwpAuLIPgwCVJ81LMNT9tzp4hLaQ=; b=GDSyebhnA6TJyNfmkTy/896b2qyBKmP6IiHTf+rgvbi9Vik8YPvrkIh3yOGaqzQ0YU3kFRY70IG/AYbgl9LdWouQIQVfTFatGV3miNSu/oyuz+0tLA4cQkPG7OsNtBkRAKG/9zLiMcKrw/TH+835E1OuaOjXqngXQ5bnENbn6HJr25GiNn0IuOck+U36x1hsT7tSp/jOIuMOxUTNBFKVPD9EPZp6kQAaI5SgAQNt3MDuyrpyQJjucUU64Jf0lcbcAVBNo3NewM/akmvU5JEt0tExCak/MJdulmLF3WfkamKxj+lWWfQq6XjzPBoo7zFQWQB4qe5f/bvY3bY4ITlxGg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fQGdzcvJ5yeA1fA0mrcR2j1eVdY/QUnrDk86EqcP58gbbQrpb49LtYPSbDveWnvrsM0ncRtx4XKYW1rovrAZiiTJm30LKSOuqDmfciLLqBMdkTBmhxS9BufdHU7TdbClUzQjtTuMy8SopQMx/3vD8ETLCKJtSJv+Nt5qxT6NOJMKGnHT1GVBObZnaEQCipgM6qC7+HYwCh+cgw4upf3TGRPwaXa7PiV0WXOwrJuAD75B55e9SA8y2IdtCK5yQ8a4rcUqSfT/ROMyBNZcBtUDHR30knRcsjBHXsHLywxIMA154q8q4AYbklrHC67+tDzi8Qg1RqteevBYjQT8WK4rKQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "Henry.Wang@xxxxxxx" <Henry.Wang@xxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Edwin Torok <edvin.torok@xxxxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 10 Nov 2022 09:02:34 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 09.11.2022 17:11, Andrew Cooper wrote:
> On 08/11/2022 11:38, Roger Pau Monne wrote:
>> Like on the Arm side, return -EINVAL when attempting to do a p2m
>> operation on dying domains.
>
> Honestly, I'd drop the comment about ARM. "the Arm side" has existed
> for of all of a couple of weeks.
>
> A far better justification is because almost all other DOMCTLs are
> rejected with -EINVAL against dying domains.
Would you mind supplying data to prove this statement? When looking
at just x86'es arch_do_domctl() I can't see this being the case for
ioport_permission, getpageframeinfo3, hypercall_init, set_address_size,
get_address_size, sendtrigger, bind_pt_irq, unbind_pt_irq,
ioport_mapping, set_ext_vcpucontext, and get_ext_vcpucontext. At which
point I stopped checking further because in the order they appear in
the file these are _all_ except shadow_op and [gs]ethvmcontext*. Am I
overlooking hidden checks of ->is_dying?
Jan
|
