[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the APIC assist options
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 7 Nov 2022 17:58:04 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SJfLxzj4Aen0EOaZb5flGHyz7PKsrvFaIHE7OOYdv1o=; b=ADh0pwfUubDLWEPFfBaKyoNHHSx2mSB8ctzZitmsJ3I1UGRuw08Ljg/iUTP0Knn6BhcYt/bMwarbL/HOpRcDz8enXhWJiQlpoTrfg1hjNu1QORffxCQ+Yhc+C98NriQk+tNUgN8SW18YHnsXiLW+1QGC7ujGQAdCm+HHQv8PquaGpD6iFVPufny4ScEjHh1j6TEOiHFu2SIX7/JPAk0dZ23XC7T5qbeO/WFNtfo9K03nLgBlwQsbb9ehBUHoU/FbscNc7ez49vh6J+T3Qr4RAoDgqUOotwSSvaxdZfmL8BkDOXSJWpd8nnZkn7Obs/iM7vGvTcz37uqt1mGPAK/ugQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ek8c9VvBWA3N0TSm+1vQxJHsZ5grOfgbwR67pjDAm5gUucu11NkrdvjPVybOtTe55SZmvegJQy+7mj89LGtp+ynaDoe6GjEVu/duXXRul7cb2+/D+TorFZyBzp4fZn/prW/YxWl924iPKW9Uscu2LjQOT6As0mW+ZC4lDgm2eb/BQOXsO09ewV7LZDu+eiRbK1h4BJZQQjXiZs6dGa3JgDvngy+xGMCozleXZ0Lz8rzA8ugzgeZKmig/kKwQj61itySwwMPxkXrMDJWFVscd0cefqoa28X7vfTJ+AGHEmn9xwpHOiePTfR9icybpXvtY7kMRmC+wx4HVTAyqDAGPtw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Henry.Wang@xxxxxxx, Paul Durrant <paul@xxxxxxx>, Wei Liu <wl@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Mon, 07 Nov 2022 16:58:14 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 04.11.2022 17:18, Roger Pau Monne wrote:
> --- a/xen/arch/x86/hvm/viridian/viridian.c
> +++ b/xen/arch/x86/hvm/viridian/viridian.c
> @@ -197,7 +197,7 @@ void cpuid_viridian_leaves(const struct vcpu *v, uint32_t
> leaf,
> res->a = CPUID4A_RELAX_TIMER_INT;
> if ( viridian_feature_mask(d) & HVMPV_hcall_remote_tlb_flush )
> res->a |= CPUID4A_HCALL_REMOTE_TLB_FLUSH;
> - if ( !cpu_has_vmx_apic_reg_virt )
> + if ( !has_assisted_xapic(d) )
> res->a |= CPUID4A_MSR_BASED_APIC;
Isn't this too restrictive when considering x2APIC? IOW is there anything
wrong with leaving this as is?
> @@ -3432,6 +3436,10 @@ void vmx_vlapic_msr_changed(struct vcpu *v)
> vmx_set_msr_intercept(v, MSR_X2APIC_PPR, VMX_MSR_R);
> vmx_set_msr_intercept(v, MSR_X2APIC_TMICT, VMX_MSR_R);
> vmx_set_msr_intercept(v, MSR_X2APIC_TMCCT, VMX_MSR_R);
> +
> + v->arch.hvm.vmx.secondary_exec_control |=
> + SECONDARY_EXEC_APIC_REGISTER_VIRT;
> +
> }
Nit: stray trailing blank line inside the block.
Everything else looks plausible to me, but from prior discussion I
wonder whether the result isn't still going to be too coarse grained
for Andrew's taste.
Jan
|
