[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the APIC assist options
- To: Paul Durrant <xadimgnik@xxxxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Sat, 5 Nov 2022 01:43:13 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WYvllwfOZD9O6T5HTCLx1s4/8S5pf4PPIIacqGUBqeI=; b=FGGcOHa91k21rCHD9LA/CO7DvhqMSGL7+BGG0tLBhFslNGM+0dbODaztSLk1Uld7o7/t31m+6v4K+4BROX6TtQXfgy56YRhjrBkuB+SkoxSw5gVy1rqn0MYqlErvaTV/+3HfNyk6A9ADeMvft1zfaVS82utw6XBiH3+6sVqu0P79QfcydaOJJxKIk3FzhTqptHb/dBU95IkCE3HxCZlOBF4JtjEJ+3FKHMU5eIgUxq8ELEjKidC0d1rURTrCE2+j/HNT0NTuGfcYHWRO4Hf4X336CjW9BXjdrM4VQo9ZJ1BbTctUxfVZBFluq/uKfb+IT1V8te3YkjZPYS6wn9iNvA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WYvllwfOZD9O6T5HTCLx1s4/8S5pf4PPIIacqGUBqeI=; b=Kj07oJuvb/MxGEQvowD/pxPi3o7pU3qRuZv7MPzatnQElgglmyY7BRwxXP4ov1mEHbh+h/pO7qzjVf4KiekNNrMeZ2kx2FC4OJkADfUug+zR2W5ILKMBadMqV/n/y9peMlli0sqWs93lB/ZX2WEMC5kGd58d0UFWFcATR8Gais9UlT0bZVBCJ7e4jolTGLlNO3kfApIn+P7iQNooDfNDWhk1HV4Esa75hSRDuFEDnF88F7S3E1l0ysesjexaNAA6gKpdJLCASLChuX0FDErF50DVuhxTFSpGpbmDjVuXT/5srxJIxMwT9Ir/mM4M18RS2PRK8f3eH/T0C96DYCJArw==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=ceq4d8y//JP/tj2VicR6XdGKkNCH1gz1/C31VLF++IeqBJQ/BIuT0ER6cLCRc0O72pe59fmfUl7tlWOiAvQM1VSKjjiM2dQlJbNV9ZS4FGcSay0mdm8NBkD4VKYgxpFzf9NOaeod3+HvicWQsNV73w7g5if8NQV2QWDT20+iWyXWfgu7WF18WwoZ5U4Gq3cCMOovNsHMp/+838swf7nXbAbO3aSoSbElamTw1m8LZw6x3lBJIoHSreuXMObvtKHyORwaelWE4FswC4UGG2/RmEMcOkfXnMNt2YzwEFQaJRe0GBP50z/MLolcM8ilzglUlT0/F+WSNFr/Skc4Ymtbvw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XYi3GSAuR8mg1+r15PiWOylG8ouHLGV4Z30owjArjKWnUXFGG69NWTQLJbYbNo7xl1QGm7se63b4uPGPuX47pCkMKZJB/3qnQ3YkwdARcRBte4sb0j2ts6y9EyZLPcM4O0T8EjrC31AgBeBo3RDUif2uJd2CUKSP+10t/lMn6F7by8vDODzmofG1sddmiE2ulHB8DqprsaQCesaRKqguFxBOEm+T2p9BRzVcw78V9MysH+5kiaQNj9PIVnLAtyzDzk37pGeJHjHV7Uh/hyQviT7XfCxOULqqT06WbXqkBPyLK3e16r8VcM1F/fb+J6398MVAEhMX99bChQmTEK0S0g==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Wei Liu <wl@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>
- Delivery-date: Sat, 05 Nov 2022 01:43:52 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHY8GkebAmmr6JZXEeYf3zz1Gj/l64vB4qAgACHc2A=
- Thread-topic: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the APIC assist options
Hi Roger,
> Subject: Re: [PATCH for-4.17 v2] hvm/apic: repurpose the reporting of the
> APIC assist options
>
> On 04/11/2022 16:18, Roger Pau Monne wrote:
> > The current reporting of the hardware assisted APIC options is done by
> > checking "virtualize APIC accesses" which is not very helpful, as that
> > feature doesn't avoid a vmexit, instead it does provide some help in
> > order to detect APIC MMIO accesses in vmexit processing.
> >
> > Repurpose the current reporting of xAPIC assistance to instead report
> > such feature as present when there's support for "TPR shadow" and
> > "APIC register virtualization" because in that case some xAPIC MMIO
> > register accesses are handled directly by the hardware, without
> > requiring a vmexit.
> >
> > For symetry also change assisted x2APIC reporting to require
> > "virtualize x2APIC mode" and "APIC register virtualization", dropping
> > the option to also be reported when "virtual interrupt delivery" is
> > available. Presence of the "virtual interrupt delivery" feature will
> > be reported using a different option.
> >
> > Fixes: 2ce11ce249 ('x86/HVM: allow per-domain usage of hardware
> virtualized APIC')
> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> > ---
> > Changes since v1:
> > - Fix Viridian MSR tip conditions.
>
> Reviewed-by: Paul Durrant <paul@xxxxxxx>
Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
Kind regards,
Henry
|