[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [v2] Proposal for deviations in static analyser findings
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Luca Fancellu <Luca.Fancellu@xxxxxxx>
- Date: Wed, 26 Oct 2022 12:09:52 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x9PSstsO5KDC5nSk/5C/x6O05/WB7bddeL7yCdPtI7o=; b=Yk1Z5j1Adp4vkh4VIoBNY98Wf02POzlwPufyAildB6/f9t9rsfi5fyqArQUvRhuIv0dVPD3NNcjUeDIq50AU9pbkJk1RjUXi1X6IamyMBNb39mkuCOMyvO9+gYpRG4gN4NGH9PS1meYG1OihmHrKMiA5o6d+cTG3TOWc0G46KBEL80PxQMDlq8F7HsXvLy2S2A+s1pwdZJZseePxFgm1hJ83Yb9yRLXQ4n76reCMCyGAC7xiH7ZCtbbwsWjQAS/sD0nyhZrL4bnnpJ/h5QaRDQRR/tKo3mGkYaDFtDIORN+yIPZQySmtPXZBDANs1szZGfzTJqhGyo0fbla9N0bLBg==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x9PSstsO5KDC5nSk/5C/x6O05/WB7bddeL7yCdPtI7o=; b=ehVDLjRBIjWJPaCLOGQceH85wE80gCzTAm9EN5vqUd41Hd/iXAyvGk5jlvTeWZbnJktr7eAh47oXFQXd7nskHxGjfTwlcrtdqAZyLNUSw0JopZFzosLORry4OeGPp9gJMyLDuJ+GmPPR6FM9mADORFGLhKjnaSex8PZ+9m+MbCxsM75KUGeFAZAZzC3ifrj2Skg1fT5JcFpFp4hnrJoCSaqO6DG3n/QFff/k5WJtjuDfgphXhYaVxMNaWLWVNw/l2WRDscykgA8bF/gvyifpiw2W/hpIqbXCoXEbPibkQozCJyH2vA8mKxvdHcXlG7ITPeD7w9mXwzEWrxWcEJC7KQ==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=QcYLX8aU3EevojfQk7+C7jEduKwb/tTxos6+k0bZucYC8p6k81MspwpVzyrvVeLejXWKHKTPX7tet5RVs4iwI6JezytU9J0kw5O57QZz2Tu487Log1y3GAWt5H1Ues0bJ0243sOtSvgpHQBFh2Qhy7AUxJtkwhBz8orQhjSxN9cCcNP5I/kki7hwANWNIGapdLfM+6raH5tuoBMR0a3YLIhWDeO/pSMSiZEUxd+I1PgpfqL5804PnYcuf58jaPaLuECaccyaScN8oZWOZg1w1OTHjvT8M3cFy5seqd/5aNCpvErsjjS6mt8Gt1qSJeg3+B+gfTDxT/JGotXr/r8eSA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OxVcN8BWhTcUiimunGhTwSnYg4oZBUZvxhholUDrZ4uAJQNlErWhe3Z3htGPLO54+/L17xtSLxX44j0ZxifKl7Q0Loie+LfghAvxI0sauSMD/tH3Sw05zgsZoE33xxe/wDGszAOVCdmryHAzi0ClJURVCIOok7kpHrZ6g2UGSUycHZLQnD3CL07QYeapRH2PaoVKIXosUbmRWd96N8ipj/YkUox8+KftEnVSt7MSE4K3/pRjTpify2eUuxqPSBWtWJijEyLfFR0L2ZjFJmpoG04roZAjBw6tpkj4/2kLTNlVx2ygTX6BLnq5JpGs+Sk09MnrCfGQKeEj7CQJUe5UpA==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Wed, 26 Oct 2022 12:10:15 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHY6FpvvKvqm6eEhUKW2GdsP99AnK4gljAAgAAAzwA=
- Thread-topic: [v2] Proposal for deviations in static analyser findings
> On 26 Oct 2022, at 13:06, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 25.10.2022 12:13, Luca Fancellu wrote:
>> Here is an example to add a new justification in safe.json::
>>
>> |{
>> | "version": "1.0",
>> | "content": [
>> | {
>> | "id":"SAF-0-safe",
>> | "analyser": {
>> | "cppcheck": "misra-c2012-20.7",
>> | "coverity": "misra_c_2012_rule_20_7_violation",
>> | "eclair": "MC3R1.R20.7"
>> | },
>> | "name": “R20.7 C macro parameters not used as expression",
>> | "text": "The macro parameters used in this […]"
>> | },
>> | {
>> | "id":”SAF-1-safe",
>> | "analyser": {
>> | "cppcheck": "unreadVariable",
>> | "coverity": "UNUSED_VALUE"
>> | },
>> | "name": “Variable set but not used",
>> | "text": “It is safe because […]"
>> | },
>> | {
>> | "id":”SAF-2-safe",
>> | "analyser": {},
>> | "name": "Sentinel",
>> | "text": ""
>> | }
>> | ]
>> |}
>
> Besides the still inconsistent use of double quote forms (as also pointed
> out by Stefano) I'd further like to point out that colons still aren't
> uniformly followed by a blank (both pointed out at v1 already, and iirc
> you agreed to make both aspects consistent).
Yes, thank you for your review on v1 and here, I’ve already fixed them in my
patches,
I forgot to do that sending the v2, the final document will have a consistent
style.
Cheers,
Luca
>
> Jan
|
