[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[XEN PATCH for-4.17] libs/light: Fix build, fix missing _libxl_types_json.h


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • Date: Tue, 25 Oct 2022 12:16:32 +0100
  • Authentication-results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
  • Cc: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Juergen Gross <jgross@xxxxxxxx>
  • Delivery-date: Tue, 25 Oct 2022 11:17:12 +0000
  • Ironport-data: A9a23:XcBU3a1+jSHf6WjkiPbD5fJxkn2cJEfYwER7XKvMYLTBsI5bpzJWy DdKW2HSP66JZWTzKNl+a4i+9koDvpDXztJmHQZupC1hF35El5HIVI+TRqvS04F+DeWYFR46s J9OAjXkBJppJpMJjk71atANlVEliefSAOKU5NfsYkhZXRVjRDoqlSVtkus4hp8AqdWiCkaGt MiaT/f3YTdJ4BYpdDNJg06/gEk35q6r4GlF5gVWic1j5zcyqVFEVPrzGonpR5fIatE8NvK3Q e/F0Ia48gvxl/v6Ior4+lpTWhRiro/6ZWBiuFIPM0SRqkEqShgJ+rQ6LJIhhXJ/0F1lqTzTJ OJl7vRcQS9xVkHFdX90vxNwS0mSNoUekFPLzOTWXWV+ACQqflO1q8iCAn3aMqU92OwpOWpxq cceCzQ9R1etu9i/77aSH7wEasQLdKEHPasas3BkizrYEewnUdbIRKCiCd1whWlqwJoURLCHO pRfOWEHgBfoOnWjPn8eDo4+m+G5wGHyaTRCpHqepLYt4niVxwt0uFToGIqOIoLXFJoF9qqej mmW8GW+Uh1EDs6C7gej8l3zmMDTjTyuDer+E5Xnr6U30TV/3Fc7Fxk+RVa95/6jhSaWWd1FL FcP0jEztqV0/0uuJvHtUhv9rHOasxo0X9tLD/Z8+AyL0rDT4QuSGi4DVDEpQPwrstUnAwMj0 FChlsnsQzdotdWopWm1r+nO62noYG5McDFENXRsoRY5D8fLhaM50CrEcYpYFo2xvvSyNw3Ky h+OhX1r71kMtvIj26K+9FHBpjujoJnVUwI4jjnqsnKZAhBRP9D8OdHxgbTPxbMZddvCEAHd1 JQRs5LGhN3iG61hg8BkrA8lOLiyr8iIPzTH6bKEN8lwrm/9k5JPkG053d2fGKuLGpxbEdMKS BWJ0e+02HO0FCLzBZKbm6rrV6wXIVHITLwJrMz8YNtUeYRWfwSa5ixobkP49zmzzhZyyv9iY M3BIZzE4ZMm5UNPlWTeegvg+eVzmnBWKZ37GfgXMChLIZLBPSXIGN/pwXOFb/wj7bPsnekm2 483Cid+8D0GCLeWSnCOqeY7dAlaRUXX8Lir8qS7gMbYeVE4cIzgYteMqY4cl3tNw/wMyLiVp C3hCye1CjPX3BX6FOlDUVg7AJuHYHq1hShT0fAEVbpw50UeXA==
  • Ironport-hdrordr: A9a23:qGZGoay9mWvhdCj3IIQtKrPwJr1zdoMgy1knxilNoRw8SKOlfq eV7ZEmPH7P+VEssR4b+OxoVJPsfZq+z+8W3WByB9eftWDd0QPCRr2KhbGSpwEIcBeRygcy78 tdmtBFeb7NMWQ=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

Make may not have copied "_libxl_types_json.h" into $(XEN_INCLUDE)
before starting to build the different objects.

Make sure that the generated headers are copied into $(XEN_INCLUDE)
before using them. This is achieved by telling make about which
headers are needed to use "libxl_internal.h" which use "libxl_json.h"
which uses "_libxl_types_json.h". "libxl_internal.h" also uses
"libxl.h" so add it to the list.

This also prevent `gcc` from using a potentially installed headers
from a previous version of Xen.

Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
---

This is part of in review patch "libs/light: Rework targets
prerequisites", but that much smaller patch should be enough to fix
potential build issues.

This patch fix for example `make _libxl_types.o`, when libxl generated
headers aren't generated yet, and tools/light is clean.

For 4.17:
    build fix.
---
 tools/libs/light/Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile
index d681269229..374be1cfab 100644
--- a/tools/libs/light/Makefile
+++ b/tools/libs/light/Makefile
@@ -209,6 +209,7 @@ _libxl_save_msgs_helper.h _libxl_save_msgs_callout.h: \
 
 $(XEN_INCLUDE)/libxl.h: $(XEN_INCLUDE)/_libxl_types.h
 $(XEN_INCLUDE)/libxl_json.h: $(XEN_INCLUDE)/_libxl_types_json.h
+libxl_internal.h: $(XEN_INCLUDE)/libxl.h $(XEN_INCLUDE)/libxl_json.h
 libxl_internal.h: _libxl_types_internal.h _libxl_types_private.h 
_libxl_types_internal_private.h
 libxl_internal_json.h: _libxl_types_internal_json.h
 
-- 
Anthony PERARD




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.