Xen project Mailing List

Re: [RFC PATCH v1 01/12] Arm: GICv3: Sysreg emulation is applicable for Aarch64 only

From: Ayan Kumar Halder <ayankuma@xxxxxxx>

Date: Mon, 24 Oct 2022 19:24:00 +0100

Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none

Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MeJ/sUw4e5ZI0zFYwZA414Hze1AbzQ3gOj4SPGbq2Y8=; b=kq+Xs9YSfqxQm8b/kz1iIgjMBnmxoaPocI4S2jiqBLMfejTGa5K/U3YuCVz6cf2aM0NmG1b9dTiDV3J04mgzX6sR37YaO3RqmPbDy+Uwqj6VU+JwY7XzJAm7m1OluK+u6LojtQhiAv0mMH2SgJvNKOq9HaD8n3RyXdsdY1+rb6vM0qeyBvlHQafkSw64ax4hSGwmqP9pe2k3VaVWHH/a7vuq3F1/1vynoMZSHRS7j+OxebFYhFWtihNRJpTGfMXx+spNESYFlFeBtYLD6a5FscTQaMvmxit1dM6ROdK06wRuL6TCKVRJKxRdr2+ppGgv7Qdt5/1DA03PdyqgsaDT4A==

Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k7G2iDyQE2kqLJExg2Gy5UHAStagd/ciqRvx2s9diXInK/fuWdDzyKrdAf6tPBVzSYzo0MsD/6kRFRHHNuzq97v6jvyC0Ml/F4cJUv8MnlZ87SeplIj/JyMdylEjEfzZjQYE1IGl2qrlBqZ2fN/V/c/pcIFiIvJ2ElFb4azKirRmo6AfPj1cCJ1OD8dHq233+eJlIDCbTGlic/kZN0RJU8Dyc2HuOu+ObBFFmukwXsGvV9X7tp5sHfRy65XuFexIu21V8e2iKhhA7y5ctLpHIPQfoGdyL4dikgHAKIr6MYzQoCKI4l7f9WOuBYY3Re5IwLsyb7nvmFvEi/qkKSMoBA==

Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com;

Cc: sstabellini@xxxxxxxxxx, stefanos@xxxxxxxxxx, julien@xxxxxxx, Volodymyr_Babchuk@xxxxxxxx, bertrand.marquis@xxxxxxx, michalo@xxxxxxx

Delivery-date: Mon, 24 Oct 2022 18:24:13 +0000

List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

NACK, Please ignore this. I have sent by mistake. On 24/10/2022 19:19, Ayan Kumar Halder wrote:

Refer ARM DDI 0487G.b ID072021, EC==0b011000 is supported for Aarch64 state
only. This is when MSR, MRS, System instruction execution in AArch64 state
is trapped, that is not reported using EC 0b000000, 0b000001 or 0b000111.

Signed-off-by: Ayan Kumar Halder <ayankuma@xxxxxxx>
---
  xen/arch/arm/vgic-v3.c | 4 ++++
  1 file changed, 4 insertions(+)

diff --git a/xen/arch/arm/vgic-v3.c b/xen/arch/arm/vgic-v3.c
index 0c23f6df9d..c31140eb20 100644
--- a/xen/arch/arm/vgic-v3.c
+++ b/xen/arch/arm/vgic-v3.c
@@ -1520,6 +1520,7 @@ static bool vgic_v3_emulate_sgi1r(struct cpu_user_regs 
*regs, uint64_t *r,
      }
  }

+#ifdef CONFIG_ARM_64

  static bool vgic_v3_emulate_sysreg(struct cpu_user_regs *regs, union hsr hsr)
  {
      struct hsr_sysreg sysreg = hsr.sysreg;
@@ -1540,6 +1541,7 @@ static bool vgic_v3_emulate_sysreg(struct cpu_user_regs 
*regs, union hsr hsr)
          return false;
      }
  }
+#endif

static bool vgic_v3_emulate_cp64(struct cpu_user_regs *regs, union hsr hsr)

  {
@@ -1563,8 +1565,10 @@ static bool vgic_v3_emulate_reg(struct cpu_user_regs 
*regs, union hsr hsr)
  {
      switch (hsr.ec)
      {
+#ifdef CONFIG_ARM_64
      case HSR_EC_SYSREG:
          return vgic_v3_emulate_sysreg(regs, hsr);
+#endif
      case HSR_EC_CP15_64:
          return vgic_v3_emulate_cp64(regs, hsr);
      default:

©2013 Xen Project, A Linux Foundation Collaborative Project. All Rights Reserved.
Linux Foundation is a registered trademark of The Linux Foundation.
Xen Project is a trademark of The Linux Foundation.