[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-4.17?] test/vpci: enable by default
- To: Henry Wang <Henry.Wang@xxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Thu, 20 Oct 2022 14:29:36 +0100
- Authentication-results: esa5.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: Roger Pau Monne <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Delivery-date: Thu, 20 Oct 2022 13:29:49 +0000
- Ironport-data: A9a23:nTWSJqJypPJKabWpFE+R25UlxSXFcZb7ZxGr2PjKsXjdYENShGMDz mEYW2yFafuPMWKhL9sjaozko00Ov8XcydNqG1ZlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/vOHtIQMcacUghpXwhoVSw9vhxqnu89k+ZAjMOwRgiAo rsemeWGULOe82MyYz98B56r8ks15q2q4mtA5zTSWNgQ1LPgvyhNZH4gDfnZw0vQGuF8AuO8T uDf+7C1lkuxE8AFU47Nfh7TKyXmc5aKVeS8oiM+t5uK23CukhcawKcjXMfwXG8M49m/c3Kd/ /0W3XC4YV9B0qQhA43xWTEAe811FfUuFLMqvRFTGCFcpqHLWyKE/hlgMK05FbBJqr8sOX0Vy fAVIhYVdjCJrMHx/K3uH4GAhux7RCXqFIYWu3UmxjDFF/c2B5vERs0m5/cBgm123JoXW6+DO YxJMlKDbzyZC/FLEl4RFJI5mvbunnTleidUgFmUubA28y7YywkZPL3FYICPJILaGJQ9ckCwm D3q2E32XU8hOvuH4Aqn8layrN7+gnauMG4VPOLhraM76LGJ/UQMDDUGWF39puO24mauVtQaJ 0EK9y4Gqakp6FftXtT7Rwe/onOPolgbQdU4O8037hucjJXd5QmxD3IBCDVGbbQbWNQeHGJwk AXTxpWwWGIp4Ob9pW+hGqm8kGLiYHMtMTQ+aSIOaxMdw9PIg8YPkUeaJjp8K5KdgtrwEDD25 jmFqikimrke5fI2O7WHEUPv2Gz1+MWQJuIhzkCOBz/+sFslDGKwT9bwgWU3+8qsO2pworOpm HEf0/aT4+kVZX1mvHzcGb5ddF1FChvsDdE9vbKNN8N8n9hO0yT5FWy13N2ZDB4wWvvogRezP CfuVfp5vfe/xkeCY65teJ6WAM8316XmHtmNfqmKMIQXO8gtKFHcoXsGiausM4fFyRJErE3CE c3DLZbE4YgyU8yLMwZat89CiOR2l0jSNEvYRIzhzgTP7IdykEW9EO9fWHPXN7hRxPrd/G3oH yN3apLiJ+N3C7alPEE6MOc7cDg3EJTMLcqv+p0GKLHfflcO9aNII6a5/I7NsrdNx8x9/tokN FnkBie0FHKXaaX7FDi3
- Ironport-hdrordr: A9a23:CrMQxKw5+qOGSYH2n7uHKrPwKr1zdoMgy1knxilNoRw8SKKlfu SV7ZAmPHjP+VEssRAb6LW90ca7LE80maQY3WBVB8bFYOCEghrLEGgB1+vfKlTbckWUnNK1l5 0QEJSWYOeAdGSS5vya3ODXKbkd/OU=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Oct 20, 2022 at 10:30:26AM +0000, Henry Wang wrote:
> Hi Roger,
>
> > -----Original Message-----
> > From: Roger Pau Monne <roger.pau@xxxxxxxxxx>
> > Subject: [PATCH for-4.17?] test/vpci: enable by default
> >
> > CONFIG_HAS_PCI is not defined for the tools build, and as a result the
> > vpci harness would never get build. Fix this by building it
> > unconditionally, there's nothing arch specific in it.
> >
> > Reported-by: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
> > Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> > ---
> > While not strictly a bugfix, I think it's worth adding this change to the
> > release in order to always build the vpci test hardness and prevent it
> > from bitrotting.
>
> Good point.
>
> No problem from my side, but I think you need also Anthony's opinion
> as he is the toolstack maintainer.
This sounds fine to me, the risk is that the build could fail. But we
can easily revert the patch and reapply it at the next development
cycle.
Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
Thanks,
--
Anthony PERARD
|
