[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH for-4.17?] test/vpci: enable by default
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Thu, 20 Oct 2022 10:30:26 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KAQUSMRrd56ccAEu1NXYxB5fkpyk6gidnrJ7pjL4vWE=; b=farYdwI1x6FTsAW48Kk0KDhGoAOiS5RYt1BS29sRbpxJVm0YbppZ9f+9FBJfsWLAlleO/mxD8bXbgQipY2pwMLRp+psAV6g4w1WmEv+e5013gZoSX6XDRqD55e1H2YI5FqqLt9ouikPg7NaMXkfUMrE+cPq5zCfjqw96IoY39vMZv1uKXlm9iKh/0jVV+dR5qCyZ4NHb35IOjPM4YLqQ9Qvi2K+QSgk075vGwj6JYAkG2tNiebnz8DAm+t3it5QZmzzt1cQQLhAW5cI/UF6+VBDpLKT2D308EAnzeZztVqkxHl8mdnb1hZdrU6CnXnomcsgl5bbwG0PB9VvK2ASmEQ==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KAQUSMRrd56ccAEu1NXYxB5fkpyk6gidnrJ7pjL4vWE=; b=QkNVrXDvbfDnTutZ8lJQU6If9z0t1gpFZW/8TysTtf5POkYEY+IbUTsgxYTe27PT7rrvJ/YR7dArmdsWiybu/NXQtJWKFX/3kLs4qQUSp51V9hRpSmGd0KfQVkP+DH34Dmh2qsbjxWz3FKUcUY8atDnxNEHotC32uWNMtGdgniQNceKgXjXqGMQHwBT5NxEMJSkWZpQSCYXNgMYI2X26BcQ1GSqiEMKqsvkXfsA3PqzYcdAzESpBhvDb71QMTSuCfkHLELIYuucwx0IHu12fbpIJQg979qV/MFyPdcnYI61NeRIKV0l+w1K9p4VgUwT8k+Gfv+xcvCHWwsxkuNczKw==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=AcJncRH65v/IGTlX++36QlX6UqaAyveRO7Gu+z24rZOVJossCrl+ZSHbv9+dYvWSei9qCGQ9h9eg90/+nS26Ypb7GpV9tyxJ6ThbGi0ECmngj6d/UNbPyHJRTVgPAZWxQ4xcNixW8y333zhF1R0oSbOtHBBCWGrd1UTBlPnHfn7Di8eqI7vtKH4aEKk61zOGEJx6OF3kWY7ZmkC3S/yZ/l6hxd22c/xzkRHNZPHlPZPTb6G3ZiLNHoN9HdUlWc1ub4bB20ht355J4/2+AqrF9x3cczRGX1PL7H/uVEPJJEMajrV8Y9gz3Lg9uOC1GFjEVfswVX3siHKtZ5aCr8mYlA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GRMb3p4+jXlOUr8kMpDV+9Mj91nWHkj1TDiU/aHlIeyj6kjbwVdbPyY+DtLKw3uXwSzgMlu3MMjcqYInwJzBgeRu7XGqd/3s0BMS+1VHRnbIcS6Da/kK/38SCNIIs9gMZLQdgQrUismFmtxCxuegsCc8QaStAn2mlCAFxR1RmjFchGTnbZfadzml+gUbZbBTgBCfIiL8DbUfAPdzM24K0ODVtEC/b0b8/bzeZWJaRWwXrWkiAmxiNoiWecpOiVtzuIJuEqzRHwbn9lN4ruGSfAFwnubY76cx/Mfv54z9zZCnEZM2NQiqPFKXnkQy11hZysa7V6ZYPduAXbN/PLz4IQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Wei Liu <wl@xxxxxxx>, Anthony PERARD <anthony.perard@xxxxxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Delivery-date: Thu, 20 Oct 2022 10:30:46 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHY5G6LBoyhiXjFqUqNYD0Wl8lAwK4XFLTw
- Thread-topic: [PATCH for-4.17?] test/vpci: enable by default
Hi Roger,
> -----Original Message-----
> From: Roger Pau Monne <roger.pau@xxxxxxxxxx>
> Subject: [PATCH for-4.17?] test/vpci: enable by default
>
> CONFIG_HAS_PCI is not defined for the tools build, and as a result the
> vpci harness would never get build. Fix this by building it
> unconditionally, there's nothing arch specific in it.
>
> Reported-by: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> ---
> While not strictly a bugfix, I think it's worth adding this change to the
> release in order to always build the vpci test hardness and prevent it
> from bitrotting.
Good point.
No problem from my side, but I think you need also Anthony's opinion
as he is the toolstack maintainer. If he also likes this idea, feel free to
add my:
Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
Kind regards,
Henry
> ---
> tools/tests/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/tests/Makefile b/tools/tests/Makefile
> index 33e32730c4..d99146d56a 100644
> --- a/tools/tests/Makefile
> +++ b/tools/tests/Makefile
> @@ -10,7 +10,7 @@ SUBDIRS-$(CONFIG_X86) += x86_emulator
> endif
> SUBDIRS-y += xenstore
> SUBDIRS-y += depriv
> -SUBDIRS-$(CONFIG_HAS_PCI) += vpci
> +SUBDIRS-y += vpci
>
> .PHONY: all clean install distclean uninstall
> all clean distclean install uninstall: %: subdirs-%
> --
> 2.37.3
|
