[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v6 2/6] xen/x86: move generically usable NUMA code from x86 to common
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Wed, 19 Oct 2022 07:00:44 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZWBACWjmM3frdlb9BxYg6vvmstDvji8EwYqqLzcqGW8=; b=WzpNcWgR8EVDzlaWeLsiZcnXF5X24jGl1fdkMopl9EzyIK1YZZWC/WsoSM007YWfb1mYCpWc6EMI0yGNdHWKvFp4WhbTpNCcuG2enx1o+9mjlgQigAd1uT3vQ1Dr7JMxcZ7fF+lsAnXR4k0EY2xABGVdAAjn0lhErUv9B/p7Yo2nbdv5qnIV5w8sOMwbh5mNi62w3jMZIlGEE4vNSXM8tL3Qiq3oL7oFbU+3trgA3DJpgk8UOzZJA/hn0NSLOhuyd3+Nh1Bk91mymI46vPq4h13i581A/dl7Bl5z+Ltz7fVJOBX6IhgikrI/w/YC9o68QAk8Fje0LXfMVgztukioiw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZWBACWjmM3frdlb9BxYg6vvmstDvji8EwYqqLzcqGW8=; b=NWEpfASdRKN9hvjpES5bFPyk/7q3el0cNM4eCrBmSBMz41ADEO4CniKdP5xM9TnV3Qbm3KonM1iKgrdY283orXCmSE2YJt4pEz7yp1EYlV6P+lE2sKXjtgmbGISTBQokFiW79V2icZE5AxIRcWW3Y858/VwuW/g8LjADIxa7q2JJ/EELBM8DP89lvrRtQkbNt9yNQYXlh/0i6afSx0AsM4T9HJua7baKrnXMJHE/LAAi4+baPydf4rYldzYnM60eTkI+Y/Vd4sQDqk/f5KL7K5ykWjdyymMAHPKYD6rv6CdLDp2W4vCSUNuWt7JYXwfRaDWYUtsS6IzBmPPaozYKiw==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=j0Iy+Ev5noo7dZwOxpOMJoOXuU1cg7MdtX+38o35I5RiOmtSI5ysTf1MUKVETGwG0ab6ARuvbeik3U4TqM9Bog8b1T2suJS5nw9/QVneuV/GxERPkOOeyAnN56VIb7rgW/BGGLjgZ6JL4X9wmu0juDVji+LnronPnZ+y9rQfX7emr9MWr2SWeHSdLPLMIQclKTsBpDui/c+04tvHEBVbvTjwE6toqljIviKa4WA0Dks09C9vqUVhKkJlI3oyT1k1Y5L1L44gRZoQFZn2sMmkt7MAN75vl8iuByAcZBcTTOqFm62D/5WRr1vo6hdF4zmZ829o9k6yuu997tgXChicNw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VlcLCrHW4wWyXv+OcLCRbruRkyjCQ3Jr6Sb8ByHvarPnJ0styA1x+6YSsZ8LBd0EqmisuYNm8S2d/vKGASKZ8CyIlrXE5thrNhyzhjsWQ5QLLDNvm5KU2X6XRQiMFk+1SvNqYXLl9uhO09MRDla/0r6wZacG7M6gWhMEZt/ZGEsSVDCcLcv5yrIuMJaC/jIzPP2B6R4CwM9oQO1SqaBr+e8Z0MRfuGw8WcZnMb0DCpGTSRlf4PzJb2vxrOIlXgZ/JFJG0dlAhFQOHtG7enHeALhaGtLoesDJQNhuOZPP+EFhZxLuV3v5AC2D1K7vWlebSdJjShaCD6NlD4eBsHT/gQ==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: nd <nd@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Chen <Wei.Chen@xxxxxxx>
- Delivery-date: Wed, 19 Oct 2022 07:01:09 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHY3WMp8fkwGFUvPUGj/zptqNRTAq4UNRwAgAEdejCAAAIqgIAAAIHw
- Thread-topic: [PATCH v6 2/6] xen/x86: move generically usable NUMA code from x86 to common
Hi Jan,
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> >>> 4. Use %u instead of %d for nodeid_t and j in numa_setup print
> >>> messages.
> >>
> >> The only instances of nodeid_t typed variable uses that I was able to
> >> find are in dump_numa(). I guess you can leave them that way, but
> >> strictly speaking %u isn't correct to use for nodeid_t (as it promotes
> >> to int, not to unsigned int).
> >
> > Sorry for suddenly jumping into the discussion. Firstly thanks Jan for
> > the review :))
> >
> > I am a little bit confused here, nodeid_t is defined as:
> > typedef u8 nodeid_t;
> >
> > so I think here %u should be probably fine (I may have missed
> > something though)?
>
> %u is indeed "probably fine" (hence me saying that they can be left that
> way), but from a strict language perspective it isn't: unsigned types
> more narrow than "int" promote to "int", not "unsigned int" (and type
> promotion kicks in when passing arguments to functions where only
> ellipsis is specified, i.e. parameter type information isn't available).
Ah yes, sorry I should have thought deeper. Thanks for your detailed
explanation.
Kind regards,
Henry
>
> Jan
|
