[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH][4.17?] VMX: correct error handling in vmx_create_vmcs()
- To: "Beulich, Jan" <JBeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: "Tian, Kevin" <kevin.tian@xxxxxxxxx>
- Date: Mon, 10 Oct 2022 23:19:14 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/nJSzPrbw8ZQgYvNNmNknEKOMk9hCAwrRnSkpx/282U=; b=CqXGmRn5eM78anz5GJ0iu2T1Q8HDEBDI58L/DnTaUXEPic+Ir7yyVsZ+Sb00UYgzBoyG80rvliNVbOCH789u2cRG3jLWfjgGcao3pLHehM/hPLQDTB3u/fV4wDFqGbDKTC5aXk3E0qN3RDj29t2vZ87g59K3/ZOMTE/zUaIlmXLLrcJqqxB1aimAUBlOl6IqFedfZR8qxxTkOm2SxjH/zRy8sAAPKux1zPxNa7zg+lAb27V16ljv2Uclar24W0W6G8ZKDILgvOarMStJAWFmYMLGHrQbTMZGKts9OIR0OaCO4ueOXn0lnF0RyxGVrxcvIkUtvRz+ietCHj/1TxrpUg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a3DdD/ZHS7WVy9Rp/XB4X90lae9Jj3Nd26DfjsO/UXpcFxOMGBWjdFv03tg7umAmhcgNfN/p93F1QLlOwMIGpQE4f2j/dM84NGZSCmecUzZsxrceHYZJBhwBj1uzCpAkfz8FpHkQHslx/i0Hrh2AZhPSJI8LNeAFZIoiHgyqllYr47N9oNeZvLkQTcZG7PojQBzBZKauyIK9o00tBq3stqggYLfDBb+ypcnbmfIPSPbo9CZzquEgGbV0vhqiviK6WMYxdD6uB4tUCrOOyS2VqRijIvFgBjRinf1wQQhlfHmnexYPvQajZjYIZ63q+T/Jjqu55lDnzcjjbPWQBvfk6A==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com;
- Cc: "Nakajima, Jun" <jun.nakajima@xxxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Pau Monné, Roger <roger.pau@xxxxxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>
- Delivery-date: Mon, 10 Oct 2022 23:19:38 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHY3JKipcgRyk6QSEu91qZECWaYba4IRCqQ
- Thread-topic: [PATCH][4.17?] VMX: correct error handling in vmx_create_vmcs()
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: Monday, October 10, 2022 6:25 PM
>
> With the addition of vmx_add_msr() calls to construct_vmcs() there are
> now cases where simply freeing the VMCS isn't enough: The MSR bitmap
> page as well as one of the MSR area ones (if it's the 2nd vmx_add_msr()
> which fails) may also need freeing. Switch to using vmx_destroy_vmcs()
> instead.
>
> Fixes: 3bd36952dab6 ("x86/spec-ctrl: Introduce an option to control
> L1D_FLUSH for HVM HAP guests")
> Fixes: 53a570b28569 ("x86/spec-ctrl: Support IBPB-on-entry")
> Reported-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>
|
