[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH][4.17?] VMX: correct error handling in vmx_create_vmcs()
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Henry Wang <Henry.Wang@xxxxxxx>
- Date: Mon, 10 Oct 2022 10:53:19 +0000
- Accept-language: zh-CN, en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GVWEMsvpSV6M9Z34qOHiGgzzMXl2a+1Jgr+E0j4hWJU=; b=F+sBsb6QcS5/aQeSkAmB2TzyiJb9vNZ8/2PqW/IATaL7DiBp2s42+DkIO/OT9cgUxDY++cCcOmWSJoDx9MZfXu7dipxlE/4fssvGGCLCDHdlilt0n6P6+OUloI9bAOh13nmoX5lyTwF4zWeSqYeRSbgfFC+rKRWlIieAd8ltSgqm0BQsxvhChBQLP1lVg0HlxiK9Hm5FwYngaZrN5+IFiCVTym8OET4RpdI5LCxhK+FE6gbIV/voQQKdRfYupkKFUUBgvhflQOv2HVFJI4DIQP4Q3U3m1xnDEvis6kZwDySJ/klOtaBMfg5pmFZRXPZYb+SN3OHKXET04/Al+8vClA==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GVWEMsvpSV6M9Z34qOHiGgzzMXl2a+1Jgr+E0j4hWJU=; b=VgC0aiB4wtRO5ZstMwUlK8gj1w2K8WXC8/TN3QeI9XOII9pHojlbVWlpPYttzVrjcSxPTqxm/1wGrO2VuzwOM2iW17okZHpCtbpAeTDHXfQcaF0YK8jQ9F9qVFZc0upeNqU78O1IH62+fuR9sO5MMLLz6gZgFITPwm3Iz2L2LviHhLp1jeV5ne40WEy8+wFqCzhAEW8QWhWelLcDvgGP9bnolnC+CH9OnltomIyJPyAkxlAD7P2gOxse5FYriJ3VZZUt/eeTW0kxVPYMhMd4PZF/F72Bf29Z+VL90jh6WgRwrilEa3/wMeDrqJ0rBEVfzyGqSJzig/tnZvVURA7G/A==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=dx2Zqf+nhiHhdXb2pUTj2t+93oSIdlzurQp9ESi0OkRJ11rWrE+ylRA9wK3DdwZyecMAfcv8GiWyiXvcQ3A3ydCBvkF8mxnSwb0KDdaAZouWIrALPhsSiQ7qGU7odxNqZhtQGpWAKmTLjuH8T8NJXY75RNkIE13I0qbNm3LVv/SKG6XWJzwEAVBelFCfFztzgK55TzqUIFpwZSVgCSNZOKDr/r9s2pd49zRVqZQxIgdJ056qwwWVKi4fRn512ayn64tlwLbC68vFw9DhKC1m5390BdvUVHlELB14FOpjosO8t4jPQ4/maNnQvg/WvZkkcCikPF4YyzxqiHsqVdjHRg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G77Hs/dBEz0zoRMRByVmWg36KyjHe4WP1XwADTND/g9yGMww17Bab0h7CgyYGTaDHF/9T+7RcuSOxUshv124pz7NC0iryWktSkzQ/p8fHdJ2+IIPofMlfWGRze645tl7nhnEJlne2qx5Sg8D3SifcuKEzhQPeiOPpOg9Q2JIdaK/t2CgE0kMPOqHXtwkgjv33MGjV+xrHx8XyBOhY4C53ylGRIdctRTvhY5457PYByBexkS193Oc5cCnpkzX5n2Vlmk+6Nsw6UZi67hw7HjYAGvdIt2S6/sQI6XnQXQ30u17m0NIEsLZueBp6k/6ekdXh3CeGiQfHxLg19DrLUE65Q==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: Kevin Tian <kevin.tian@xxxxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Mon, 10 Oct 2022 10:53:41 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHY3JKk95KKydAo1UWcu6C5J8zQU64Hckhw
- Thread-topic: [PATCH][4.17?] VMX: correct error handling in vmx_create_vmcs()
Hi Jan,
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Subject: [PATCH][4.17?] VMX: correct error handling in vmx_create_vmcs()
>
> With the addition of vmx_add_msr() calls to construct_vmcs() there are
> now cases where simply freeing the VMCS isn't enough: The MSR bitmap
> page as well as one of the MSR area ones (if it's the 2nd vmx_add_msr()
> which fails) may also need freeing. Switch to using vmx_destroy_vmcs()
> instead.
>
> Fixes: 3bd36952dab6 ("x86/spec-ctrl: Introduce an option to control
> L1D_FLUSH for HVM HAP guests")
> Fixes: 53a570b28569 ("x86/spec-ctrl: Support IBPB-on-entry")
> Reported-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
I think the change makes sense to me and it is quite simple, so I would
not object to having this change in 4.17. With proper review/ack from
other x86 maintainers:
Release-acked-by: Henry Wang <Henry.Wang@xxxxxxx>
Kind regards,
Henry
|
