[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH v5 5/6] xen/x86: move NUMA scan nodes codes from x86 to common
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Wei Chen <Wei.Chen@xxxxxxx>
- Date: Fri, 30 Sep 2022 01:40:36 +0000
- Accept-language: en-US
- Arc-authentication-results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=lists.xenproject.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com])
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n0tYdRF1uMknpB0KEvfUZ1am4t4d6QbYvKcLNfle6uc=; b=nbFVVT4pFAh2cuhCCvaFFumMUOghMfJX+IHrqsM/jvFg8QTvC3BP3YDs/ZWbu9Wl19gdIjZLxwXlful4zq/4ZL0Rtq3vwAFcNNU61J/tRbAU/sAO1rHe/vPg+21OA2F8KhpROTzq5kDhj8JPyQ+Iz4QET/isirZfyE8OyzpULmRwPyV6NSYDPvTUdwoZjfZulqnZlxv2ADoOWYA3+vw3aug/s4+za64qdNDwgKi4xChClkbbYH9zZ89wBiRxdiZ28DbIl/ukXSeYveWkjay2Dsoy76BHNRyjyQcxu+OvUgmxboQbGXPZ2M1oq15iYwwg8Ngl47xzkE8s4g7SV8Q1iw==
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=n0tYdRF1uMknpB0KEvfUZ1am4t4d6QbYvKcLNfle6uc=; b=GOVCAOqlytqcbjUn85dz60ZLNrUZZwWeVMdLWWhQha6wICUxr6J1R5Y04DB5YGSe1xKfCjXB0nfuRcR0FU2jgd/JtyqZAv0R5v+dLefcA0R5iORjHzx8q4gDZQ2haCpsVkjniluOq1p9wXmV3pdeDQLyocCGTZ5729IlF1ErPEVysFRejnd4lVEcTJ/dcF5Km51hexQNzLj0QerrE+iFbkjcCaOCGxYs/w6NxIVpi5t0ldgsOlgHMCT9Q506puua3+e8tZArZ7ao/0/JUWiU/XYaduINxQQ1+Jyp7m6bk+nj0yN1RSmHXfSmAOdIQw6R6xGkP1v0CBGzNN378qQxkg==
- Arc-seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=IAlHIPUh9VXr9pv1OX+pqiwmCzvyOvKl02/jhlqujytW7JqycJOX6ZYCCUoDx1d9CfuVgSaEcs3Zuv3JolPdUqJ5J3rme9zQXIwRuAif/K4vPA67tSh6mt5SyBOpfs5y7Wwa3wILLuklB2RvLaryy/cgVEkyvXiy5w2DTfDoEXwexIINtFQqwbJc/MSEA6PaRl43UMpyb1XQIelKbfDIPpj4itMzagyovu2psAMYvBhFbWisUdDPZxqYaW3LDpE16S0OYCJjh8/5dk6rg8yQVPyWfx1NZ2jlM+kfkzxm8ieyNqBR/UbMFnmYowwbNshV/d/Q6xjdWOVjtFsJEsw5iA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TnS0oYYDMoVzeBwDxHW6IplaSWK6BsFmSv6gQlPr2w/UIJ3UjCosNpGCjCUfjEMuCnqfyAnV2QabJiQzSeI0yqZtiaW5NLjv826K9zF1qvKKvLYzQfPPJVgAtcLeyfwNBwh2MO8VcGd0fMmXJk3z7DEq3UIBtmPkqP+ifPHugK2nfPOuoHUVJ/RbjQW4BnK+ZwRj5eNtpUba+WbuBrpz1xplmoy1Kk5tNu8PlUUR37U21rp/aTUbQYfE/53vLwtwUxoqUQ9OKSOrGRM+VnehpVyeO6Z4d6FGWSU037LW/w/d7XI4SBw6Jt3E0aQypFXhPq2ujrSNNla3hjHC8Au8vg==
- Authentication-results-original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Cc: nd <nd@xxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 30 Sep 2022 01:41:17 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com;
- Thread-index: AQHYzNExhaWvtVxVf06aoC2sQxI0u63zd60AgAKngwCAAEMigIAA3nNw
- Thread-topic: [PATCH v5 5/6] xen/x86: move NUMA scan nodes codes from x86 to common
Hi Jan,
> -----Original Message-----
> From: Jan Beulich <jbeulich@xxxxxxxx>
> Sent: 2022年9月29日 20:21
> To: Wei Chen <Wei.Chen@xxxxxxx>
> Cc: nd <nd@xxxxxxx>; Andrew Cooper <andrew.cooper3@xxxxxxxxxx>; Roger Pau
> Monné <roger.pau@xxxxxxxxxx>; Wei Liu <wl@xxxxxxx>; George Dunlap
> <george.dunlap@xxxxxxxxxx>; Julien Grall <julien@xxxxxxx>; Stefano
> Stabellini <sstabellini@xxxxxxxxxx>; xen-devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [PATCH v5 5/6] xen/x86: move NUMA scan nodes codes from x86
> to common
>
> On 29.09.2022 10:21, Wei Chen wrote:
> > On 2022/9/27 23:48, Jan Beulich wrote:
> >> On 20.09.2022 11:12, Wei Chen wrote:
> >>> --- a/xen/drivers/acpi/Kconfig
> >>> +++ b/xen/drivers/acpi/Kconfig
> >>> @@ -7,4 +7,5 @@ config ACPI_LEGACY_TABLES_LOOKUP
> >>>
> >>> config ACPI_NUMA
> >>> bool
> >>> + select HAS_NUMA_NODE_FWID
> >>> select NUMA
> >>
> >> While I might guess that you've chosen the insertion point to have
> >> things sorted alphabetically, I think here it would be more natural
> >> to select the wider option first and then also select the more
> >> narrow one.
> >>
> >
> > Ok, I will adjust the order.
> >
> >> One further question though: How is this going to work for Arm64
> >> once it wants to support both the form of NUMA you're working to
> >> enable _and_ ACPI-based NUMA? There better wouldn't be a requirement
> >> to pick one of the two at build time - it would be nice for support
> >> of both forms to be able to co-exist in a single binary.
> >
> > We are also working in this way. In part#3, we will check ACPI first,
> > only when ACPI is off, the DT NUMA will be used by Arm. If ACPI is on,
> > we will skip DT NUMA.
>
> Even more so an answer to my question would be nice: You'll then have
> CONFIG_HAS_NUMA_NODE_FWID=y even on Arm (using PXM as mandated by ACPI
> when in ACPI mode). But then what's the FWID for DT? I know it was me
> to suggest this build time distinction, but I'm afraid I wasn't doing
> much good with that (and I'm sorry).
How about introducing a flag for selected NUMA implementation to
set it in runtime?
For example:
bool numa_has_fw_nodeid;
ACPI NUMA will set this flag to 1, but 0 for DT NUMA.
Cheers,
Wei Chen
>
> Jan
|
