[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 5/6] xen/x86: move NUMA scan nodes codes from x86 to common
- To: Wei Chen <Wei.Chen@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 29 Sep 2022 14:21:19 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EASFL+Yy2MgNjdTH+kUTqgOKursNorO1SSpvvIuqxfg=; b=Z08Mp8q7j1ZXvD69MxCTNuFly+UjpQR7cap/SF7q3etAck6GVCHKX+3GsJEukJtXfnPD/hr8f5fyle0o/dGs3YVGWfMKAQ15/wGDZt+20NuZe1A1YAXVRi8vrWkkgq7zuYvbVtlsbTxDFDADFZFmjLhlH/qgvj9oKxegYjeKNK5Sq5Hq3CsfNAsSYuBpRwTTRQlgDdRj+63v3zQqJXNKx57huweCr+Bq49spFxXM2zjh6mMz5UQpjOaI8wZQqtHgjyOz2eIYOe5GJkoQWpH+z05fKaY22i9vsvRx9LuiXz3N+QBV+ILGsJhBSr18RNxS45bWmkt548p0VsGNSsSQLQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Vr02ompGWdaXk3rWvA0Wakzpu5X3AOPCvJaZOTM2PWDAAEeqzoeQW/6p2/lEb/MvtDvBm/pKt0Y3DBKYxlL6sdHz7AkCGU3WR2tBE7VAUMTZHf942aIpkI67J2ct8It6/KCqaGgoAh1EG/eFNr3mUjxAAwc7MTktzFPLaMBvWikJFTE9VzQSRiVJPsSmTX28prXSvJOj21uQNWOFAakxRKDyWosR0HBVJ8VjqPgadVl6tfblGNnGJxdWkf0HisQCr7KhJcCk2ROoO+JREMpaa0GYibp6VcqNl6tQheHoVHEIVYXRuuGKhObrpPS2DChSmwO66M9Eh5wN4MZ4Mc/I+w==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: nd@xxxxxxx, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 29 Sep 2022 12:21:41 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 29.09.2022 10:21, Wei Chen wrote:
> On 2022/9/27 23:48, Jan Beulich wrote:
>> On 20.09.2022 11:12, Wei Chen wrote:
>>> --- a/xen/drivers/acpi/Kconfig
>>> +++ b/xen/drivers/acpi/Kconfig
>>> @@ -7,4 +7,5 @@ config ACPI_LEGACY_TABLES_LOOKUP
>>>
>>> config ACPI_NUMA
>>> bool
>>> + select HAS_NUMA_NODE_FWID
>>> select NUMA
>>
>> While I might guess that you've chosen the insertion point to have
>> things sorted alphabetically, I think here it would be more natural
>> to select the wider option first and then also select the more
>> narrow one.
>>
>
> Ok, I will adjust the order.
>
>> One further question though: How is this going to work for Arm64
>> once it wants to support both the form of NUMA you're working to
>> enable _and_ ACPI-based NUMA? There better wouldn't be a requirement
>> to pick one of the two at build time - it would be nice for support
>> of both forms to be able to co-exist in a single binary.
>
> We are also working in this way. In part#3, we will check ACPI first,
> only when ACPI is off, the DT NUMA will be used by Arm. If ACPI is on,
> we will skip DT NUMA.
Even more so an answer to my question would be nice: You'll then have
CONFIG_HAS_NUMA_NODE_FWID=y even on Arm (using PXM as mandated by ACPI
when in ACPI mode). But then what's the FWID for DT? I know it was me
to suggest this build time distinction, but I'm afraid I wasn't doing
much good with that (and I'm sorry).
Jan
|
