[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2][4.17] x86: re-connect VCPUOP_send_nmi for 32-bit guests
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 29 Sep 2022 13:51:17 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Z2PtSB3OT0mrizKCvgBTMsnzXOjkkCSAzDqw7JVJSiA=; b=eAfJDaOxOEvI9/53tBPx4wN9GZBZkY7nuY9ASjvIdvIflWVe1toFaebrFpcZ1kQVOTbRrsAhmtUMX6/OFF2/RBdaDUs6N8OOH3gC6g28MhNLpHghD7F17pcIvEn96LxZfR2kHCrWOkVubYhXWGjwWg9bdz2XS99hJOgb2vT5V+d5TJB8W8G4JO1EI1MAFGnnPT3Wly8bFtPF/8ePptDtUIKLptz0ily0bG0HGt3J7i7lDbcD2xOLW04Yp6j48s1kmxLxREramd+BNerwmKA6l5mYi6fPNkDLn4NiM/jtl9O3xktW2SHcwKSONPVm3c2ZeDj/h/W9LOw3ExfXsCn5lg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PjI51F9RBc+L/9/ya6KIMWisD5uK1+DLpiZ5TpuETCQgCC/lBg4b8REkB8XzuhFCRFjtYgYWst5VT5bTN8zCV1yTMmraGZ74MMiuqtkF99c8ckTxuH8fc27CfSHrfb5vvCUfOEfXyduRHCWVTlMpWpGkObbbDoM8B4TtQCxShlzEvb3Ewcmp2r6MF7IFrHpAoJosoJgfhm46ZxdOHsM7xPqGv8zsupmI34K1IymU/K+BW5yap7Ckp4ZObxAIBKu8Z7dSq63dF+IistzwWyWmuIfzTRIMZ3twZqpU1lVew2asD/EfBfSYiH1LQoI6rjOseXuNM0BM9+S5uzL6kRVBDA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>
- Delivery-date: Thu, 29 Sep 2022 11:51:27 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 29.09.2022 13:11, Roger Pau Monné wrote:
> On Thu, Sep 29, 2022 at 11:51:03AM +0200, Jan Beulich wrote:
>> With the "inversion" of VCPUOP handling, processing arch-specific ones
>> first, the forwarding of this sub-op from the (common) compat handler to
>> (common) non-compat one did no longer have the intended effect. It now
>> needs forwarding between the arch-specific handlers.
>>
>> Fixes: 8a96c0ea7999 ("xen: move do_vcpu_op() to arch specific code")
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Thanks.
> This seems prone to errors, I wonder if we should add a note to
> do_vcpu_op() to notice that hypercalls handled there need to be
> explicitly forwarded from compat_vcpu_op.
Perhaps. I guess if such a comment had been added by the original change,
the mistake corrected here would have been noticed right away.
> I've also noticed that compat_common_vcpu_op() forwards
> VCPUOP_set_singleshot_timer to do_vcpu_op(), but that seems to be an
> useless jump, shouldn't it forward directly to common_vcpu_op()?
Looks like another (less severe) oversight, yes. Do you want to make a
patch or should I?
Jan
|
