[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2][4.17] x86: re-connect VCPUOP_send_nmi for 32-bit guests
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Thu, 29 Sep 2022 13:11:45 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=N4COfsltNZK/AWvNwM+XQ+1QAEOsZ+dW/FHxAu99r5M=; b=ElGYeODdXz7JaBpquI6oga9/kYb2bfsCmayWVyqQGdTIk0z7uM5o7Zws5nQUKfaPl1DyyKjVXSnm7Gay1xGMOyEfAp7OuJcvxicDQw81dsv5vdFQ/2wtUhHj1a6QrBk69AWJSjDnH3+J+mW5y22PoqR1l1w7/259YcCcTlFka0If0przW7XdQF90PJSRy3hMBe3nK52QPfZR488IlCGe8o09I59rAnt0g+BmSUUWho4pgXEh9qByMVGdwuDPZOixwAtvm1+wLG6t0q1aGiFOE35EuzvakvT47VVRT8gv5kvySbO70jEdiW/3oRY23Br3gNSFeZ5HdstYXEnY/Ay9vQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Qzn3/WPWjBYLUqC9KkO8G7SK4JpiMZYL4vPizTsQlCo3KA+F1VNIal57dKmDKrVT2w2Z/6Z+mINVmj4AZrBLeORJbVnMN5kEo+DteLDwFh6ruSMCsecJgK+QcdpfvcWpl6BWxZOcoLeGkc9eu0oV2D11gBoIDPiFEfgqM9nlsrG7882mxlOriAq3+XVmlXGJ7XTYxyr/oNOEcKPa6PqvUI04uZC4bryCObVHnjQ2w4xpH/htEUZVEEDTTf/dd3TusZfLw20uRfbXqxglnpE0iNfwJ+Ti6nP4SeTSU+umoeNcL/+685UaBhk90EcrpVSqhM6YQrNGKEixUMfzFj9u4Q==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>
- Delivery-date: Thu, 29 Sep 2022 11:12:01 +0000
- Ironport-data: A9a23:qJSmqqJG8gThWeihFE+RDpQlxSXFcZb7ZxGr2PjKsXjdYENS1zMDz WIZW22EOvaLYzSgLt5/a9uyph4PvseHmNNrGVBlqX01Q3x08seUXt7xwmUcnc+xBpaaEB84t ZV2hv3odp1coqr0/0/1WlTZhSAgk/vOHtIQMcacUghpXwhoVSw9vhxqnu89k+ZAjMOwRgiAo rsemeWGULOe82MyYzl8B56r8ks15qyj4mJA5zTSWNgQ1LPgvyhNZH4gDfnZw0vQGuF8AuO8T uDf+7C1lkuxE8AFU47Nfh7TKyXmc5aKVeS8oiM+t5uK23CukhcawKcjXMfwXG8M49m/c3Kd/ /0W3XC4YV9B0qQhA43xWTEAe811FfUuFLMqvRFTGCFcpqHLWyKE/hlgMK05FbUn66VwKmh2z 8MzFTIhVA+pqLOS/73uH4GAhux7RCXqFKU2nyg6iBv/XbMhS52FRLjW79hF2jt2ntpJAfvVe 8seb3xocQjEZBpMfFwQDfrSns/x3iW5L2Ie9Q/T/PVpi4TQ5FUZPLzFKt3ad8bMXcxItk2Zu njH7yLyBRRy2Nm3mWbcqCzw3rOncSXTQYBDDeGa76FQvWaQmzwZLl4Sfnu/vqzs4qK5c5cFQ 6AOwQIsp6Uv8E2gTvHmQga15nWDu3Y0S9dWVuE39gyJ4q7V+BqCQHgJSCZbb94rv9NwQiYlv neLgtfoCDpHoLCTD3WH+d+8tiiuMCIYKWsDYy4sTgYf5dTn5oYpgXrnUdJLAKOzyNrvFlnY4 z2Mtjl4uLwVguYCzaD99lfC6w9AvbDMRw8xow/RDmSs61ojYJb/PtP2r1/G8fxHMYCVCEGbu 2QJkNSf6+ZICoyRkCuKQ6MGG7TBC+u5DQAwSGVHR/EJnwlBMVb6FWyMyFmS/HtUD/s=
- Ironport-hdrordr: A9a23:pAHr7688VR9nRLzMoTFuk+FDdb1zdoMgy1knxilNoENuH/Bwxv rFoB1E73TJYVYqN03IV+rwXZVoZUmsjaKdhrNhRotKPTOWwVdASbsP0WKM+V3d8kHFh41gPO JbAtJD4b7LfCdHZKTBkW6F+r8bqbHokZxAx92uqUuFJTsaF52IhD0JbjpzfHcGJjWvUvECZe ehD4d81kydUEVSSv7+KmgOXuDFqdGOvJX6YSQeDxpizAWVlzun5JPzDhDdh34lInty6IZn1V KAvx3y562lvf3+4hjA11XL55ATvNf60NNMCOGFl8BQADTxjQSDYphnRtS5zXkIidDqzGxvvM jHoh8mMcg2w3TNflutqR+o4AXk2CZG0Q6W9XaoxV/Y5eDpTjMzDMRMwahDdAHC1kYmtNZglI pWwmOwrfNsfF/9tRW4w+KNewBhl0Kyr3Znu/UUlWZjXYwXb6IUhZAD/XlSDIwLEEvBmc0a+d FVfY/hDcttABKnhyizhBgu/DXsZAV4Iv6+eDlMhiTPuAIm30yQzCMjtb4idzk7hdAAoqJ/lp T525RT5c9zp/AtHNNA7cc6ML+K4z/2MGXxGVPXB2jbP4c6HF+Ig6LLwdwOlZKXkdozvdAPpK g=
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Thu, Sep 29, 2022 at 11:51:03AM +0200, Jan Beulich wrote:
> With the "inversion" of VCPUOP handling, processing arch-specific ones
> first, the forwarding of this sub-op from the (common) compat handler to
> (common) non-compat one did no longer have the intended effect. It now
> needs forwarding between the arch-specific handlers.
>
> Fixes: 8a96c0ea7999 ("xen: move do_vcpu_op() to arch specific code")
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
This seems prone to errors, I wonder if we should add a note to
do_vcpu_op() to notice that hypercalls handled there need to be
explicitly forwarded from compat_vcpu_op.
I've also noticed that compat_common_vcpu_op() forwards
VCPUOP_set_singleshot_timer to do_vcpu_op(), but that seems to be an
useless jump, shouldn't it forward directly to common_vcpu_op()?
Thanks, Roger.
|
