[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] x86/ept: limit calls to memory_type_changed()
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Wed, 28 Sep 2022 15:15:45 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AZ9fy1MLmK7l6yRaSi2cGiNMcgrW14jSAOoPB9Z719M=; b=ItcdoAH1Ff78Z/TAc8tRk/WB+he4Kr1/vMFyapZARnKLTYa9lxvXM/DS5aFwIxgUMH784MTae59iyBpM77FoqRrwdOXqisOTqT6wBk9Dm2EIEwsOTn7Om9VI73hrMXtrUnYSOJosOU6HOLtH7CybET5bEFWaJoFWkSwBj0Wcr9XHz/cPXnsaowJrLKBNI6D2LdTBWCoxUVLO36oNzGrsZmZqlLGHS8jyRCgpJuDRZDuKCrlK6K2BDzh7Y2xtPIPDay6xBwrs+eRpDexzv78UxNo1BApv6zKtBNXipzxOb8hOADrHFoqRaXlfKvjCTvOsfDEb8BHNLw2F3pYJ7tROMg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y0GFl4VqZr7DfmBRjBwzB6+L71p/hd/KnwKIoHGHWbdiWCvk4khyPekg7nLcvXUdvMDPx1bSkGHCVV9ojR7qlSGMaBqbPs3D2H1jrimy7TzMc4ueuGTYRq/R7DLinKNuMs9NvU1xZJuXXKB/PJaQS1pWU01m8fWk5E8m8XahduErUV5h36h3Xfr1eaDaPhQbYiX2xX8JJoCrX10CQPAEhoPGYkoQoIxkjnHE7WqtDc7IRM9Vk752cuh0+Wg1DN1ScIyD18JnkK3JIoCH+TsLTECgX/vaxPsGSHh6CMxpsYhFJtSmmUe0QeSiU4cOlwgtbHtnsFNT40XBobLUJUwOAg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Wed, 28 Sep 2022 13:15:56 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 28.09.2022 15:08, Roger Pau Monné wrote:
> On Wed, Sep 28, 2022 at 12:45:13PM +0200, Jan Beulich wrote:
>> On 28.09.2022 12:08, Roger Pau Monné wrote:
>>> On Wed, Sep 28, 2022 at 10:01:26AM +0200, Jan Beulich wrote:
>>>> On 27.09.2022 17:39, Roger Pau Monne wrote:
>>>>> --- a/xen/include/xen/iocap.h
>>>>> +++ b/xen/include/xen/iocap.h
>>>>> @@ -7,13 +7,43 @@
>>>>> #ifndef __XEN_IOCAP_H__
>>>>> #define __XEN_IOCAP_H__
>>>>>
>>>>> +#include <xen/sched.h>
>>>>> #include <xen/rangeset.h>
>>>>> #include <asm/iocap.h>
>>>>> +#include <asm/p2m.h>
>>>>
>>>> That's heavy dependencies you're adding. I wonder if the functions
>>>> wouldn't better become out-of-line ones (but see also below).
>
> I would expect most callers to already have those dependencies TBH,
> and in any case definitions there not used would be dropped anyway.
>
> Or are you worried about the newly added dependencies causing a
> circular dependency issue in the future?
Yes, but maybe for no real reason: Now that I look, I see that no other
header file includes */iocap.h (except, of course, xen/iocap.h including
asm/iocap.h).
Jan
|
