[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH for-4.17] Build: Drop -no-pie from EMBEDDED_EXTRA_CFLAGS
- To: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Tue, 27 Sep 2022 16:47:08 +0100
- Authentication-results: esa1.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Henry Wang <Henry.Wang@xxxxxxx>
- Delivery-date: Tue, 27 Sep 2022 15:47:40 +0000
- Ironport-data: A9a23:lTg/HKh9uCJyimvRBdKKSjTNX161WBAKZh0ujC45NGQN5FlHY01je htvXGjUbKmPYDDzeNt0bN/gpk8EvZXRy4MxHAZoqy49Fykb9cadCdqndUqhZCn6wu8v7q5Ex 55HNoSfdpBcolv0/ErF3m3J9CEkvU2wbuOgTrSCYkidfCc8IA85kxVvhuUltYBhhNm9Emult Mj75sbSIzdJ4RYtWo4vw//F+UgHUMja4mtC5ARvP68T5jcyqlFOZH4hDfDpR5fHatE88t6SH 47r0Ly/92XFyBYhYvvNfmHTKxBirhb6ZGBiu1IOM0SQqkEqSh8ai87XAME0e0ZP4whlqvgqo Dl7WT5cfi9yVkHEsLx1vxC1iEiSN4UekFPMCSDXXcB+UyQq2pYjqhljJBheAGEWxgp4KWdO0 dopATcgVw6S2uSO6uinWPNdh8t2eaEHPKtH0p1h5TTQDPJgSpHfWaTao9Rf2V/chOgXQ6yYP ZBAL2MyMlKQOHWjOX9OYH46tM6uimPybHtzr1WNqLBsy2PS0BZwwP7mN9+9ltmiFZwFzh7C/ D2uE2LROx4CbNrA9gW84lHwrNbqrA74X687G+jtnhJtqALKnTFCYPEMbnOkpdGph0j4XMhQQ 2QW5y4voK4a5EGtCN7nUHWQgHOCpA9aZNNWHMUz8gTLwa3Riy6JC25BQjNfZdgOsM4tWSdsx lKPh8nuBzFkrPuSU3313pW+oC62OCMVBXQffiJCRgwAi/H4u506hB/LStdlEYa2g8fzFDW2x CqFxBXSnJ1K05RNjf/iuwma3XT8/fAlUzLZ+C3RXkaD3yp+Sbe7dtGu0XKB8eRaHYeWGwzpU Gc/p+CS6+UHDJeonSOLQfkQELzB28tpIAEwknY0QcB/qm3FF2qLONkJvWogfBsB3tMsI2eBX aPFhe9GCHa/1lOOZLQ/XY++At9CIUPIRYW8DaC8gjajj/FMmO67EMNGPxb4M4PFyhJEfUQD1 XCzLq6R4Y4yU/gP8dZPb751PUUX7i4/33jPYpvw0g6q17GTDFbMF+lZagLRM7FpvfvVyOkwz zq4H5Ti9vmieLemPnm/HXA7dDjm0kTX9bip8pcKJ4Zv0yJtGX07Cu+5/I7Nj7dNxv0N/tokC 1nnBSe0PnKj2iCcQehLA1g/AI7SsWFX9yxmY3V2bQr1hRDOo++Htc8iSnf+RpF/nMQL8BK+Z 6JtlxmoahiXdgn6xg==
- Ironport-hdrordr: A9a23:yIAY2KHrrMK32P7tpLqE5seALOsnbusQ8zAXP0AYc31om6uj5q aTdZUgpHjJYVkqKRIdcLy7V5VoIkmskaKdg7NhX4tKNTOO0ADDQe1fBOPZskTd8kbFltK1u5 0PT0EHMqyUMWRH
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
This breaks all Clang builds, as demostrated by Gitlab CI.
Contrary to the description in ecd6b9759919, -no-pie is not even an option
passed to the linker. GCC's actual behaviour is to inhibit the passing of
-pie to the linker, as well as selecting different cr0 artefacts to be linked.
EMBEDDED_EXTRA_CFLAGS is not used for $(CC)-doing-linking, and not liable to
gain such a usecase.
Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Fixes: ecd6b9759919 ("Config.mk: correct PIE-related option(s) in
EMBEDDED_EXTRA_CFLAGS")
---
CC: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
CC: Jan Beulich <JBeulich@xxxxxxxx>
CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
CC: Wei Liu <wl@xxxxxxx>
CC: Julien Grall <julien@xxxxxxx>
CC: Henry Wang <Henry.Wang@xxxxxxx>
Henry: This bugfix is a blocker for 4.17.
---
Config.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Config.mk b/Config.mk
index 000e57e57b44..69af1e60d4cc 100644
--- a/Config.mk
+++ b/Config.mk
@@ -188,7 +188,7 @@ endif
APPEND_LDFLAGS += $(foreach i, $(APPEND_LIB), -L$(i))
APPEND_CFLAGS += $(foreach i, $(APPEND_INCLUDES), -I$(i))
-EMBEDDED_EXTRA_CFLAGS := -fno-pie -no-pie -fno-stack-protector
-fno-stack-protector-all
+EMBEDDED_EXTRA_CFLAGS := -fno-pie -fno-stack-protector -fno-stack-protector-all
EMBEDDED_EXTRA_CFLAGS += -fno-exceptions -fno-asynchronous-unwind-tables
XEN_EXTFILES_URL ?= http://xenbits.xen.org/xen-extfiles
--
2.11.0
|
