Re: [PATCH v2 06/10] automation: qemu-smoke-arm32.sh: Modify script to use ImageBuilder

[Michal Orzel <michal.orzel@xxxxxxx>]

Hi Stewart,

On 26/09/2022 16:46, Stewart Hildebrand wrote:
> 
> 
> On 9/26/22 07:04, Michal Orzel wrote:
>> Take an example from arm64 qemu test scripts and use ImageBuilder
>> to generate u-boot script automatically. Calculating the addresses
>> manually is quite error prone and also we will be able to benefit
>> from using ImageBuilder when adding domUs to this test in the future.
>>
>> Install and use u-boot from the debian package.
>> Modify the script so that binaries are loaded from u-boot via tftp.
>> Remove dtuart=/pl011@9000000 because stdout-path in QEMU dtb is always
>> set to pl011 node path.
>>
>> Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
>> ---
>> Changes in v2:
>> - add explanation in commit msg why we remove dtuart path
>> ---
>>   automation/scripts/qemu-smoke-arm32.sh | 57 ++++++++++++--------------
>>   1 file changed, 27 insertions(+), 30 deletions(-)
>>
>> diff --git a/automation/scripts/qemu-smoke-arm32.sh 
>> b/automation/scripts/qemu-smoke-arm32.sh
>> index 530f3892fdd3..765facbe4d66 100755
>> --- a/automation/scripts/qemu-smoke-arm32.sh
>> +++ b/automation/scripts/qemu-smoke-arm32.sh
>> @@ -4,7 +4,9 @@ set -ex
>>
>>   export DEBIAN_FRONTENT=noninteractive
> 
> While you are here, there's a typo. s/DEBIAN_FRONTENT/DEBIAN_FRONTEND/

This is a good catch. Thanks!
It looks like all the Arm scripts use FRONTENT instead of FRONTEND. This is 
clearly incorrect.
I will need to fix all the occurrences as part of this cleanup series.

~Michal